-
Notifications
You must be signed in to change notification settings - Fork 16
Added time taken feature #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: vr-varad <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Varad😊,
I think the terms "module" and "course" should be considered based on their usage.
For our Layer5 docs' overall section pages, even though they primarily act as navigation, they still include introductory content and explanations. In this case, showing a time estimate seems reasonable.
Also, it makes perfect sense that there's no time displayed for the "knowledge check" section.
However, if we only intend to use "course" and "module" as simple hierarchical distinctions, then we could remove the time display for these types.
By the way, it looks like the CSS for the time display is broken here.

There's another question I'm not sure about it: when the site actually renders, does it use the Hugo YAML files from the theme repository or from the build repository? If it's the build repository, then we'd need to modify those files in the build repository, or is there some way to synchronize them? |
That is why I am sending it over JSON so it can be used as required @zihanKuang |
Signed-off-by: Varad Gupta <[email protected]>
Signed-off-by: vr-varad <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vr-varad this doesn’t exactly answer @zihanKuang questions or fully deliver the feature.
Merge conflict.
Signed-off-by: Varad Gupta <[email protected]>
@zihanKuang |
@vr-varad, offer a screenshot when the CSS is complete. |
Signed-off-by: vr-varad <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vr-varad, what do you think about moving it above? I feel like since 'time' and the other tags aren't aligned anyway, we might as well move them outside the frame.🤔

Signed-off-by: vr-varad <[email protected]>
Made the time taken above the tags and categories. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Notes for Reviewers
This PR adds reading time to all the levels.
reading_time
in minutes.We could use
hide_readingtime: true
in the metadata so that the read time is not shown on these pages.This change could be made on the archetype as well.
Signed commits