-
Notifications
You must be signed in to change notification settings - Fork 166
Clarify comment notification behavior and owner-specific muting rules… #923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Bhumikagarggg
wants to merge
4
commits into
layer5io:master
Choose a base branch
from
Bhumikagarggg:Comment-section
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+23
−5
Open
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
9d57e9a
Clarify comment notification behavior and owner-specific muting rules…
Bhumikagarggg 929bdee
Merge branch 'master' into Comment-section
Bhumikagarggg b8cbeb8
add alert
Bhumikagarggg 7b5e95c
Merge branch 'master' into Comment-section
Bhumikagarggg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -201,11 +201,17 @@ Each time that a new comment is made in a design, remark placed into existing co | |
| <figcaption>Example email notification received when design comment is made.</figcaption> | ||
| </figure> | ||
|
|
||
| As the owner of a design, you will recieve notification each time a comment is made in your design. Tag other users and have them receive notificaiton of your comment by mentioning their username with the `@` symbol. | ||
| As the owner of a design, you will receive notification each time a comment is made in your design. | ||
|
|
||
| **Note:** | ||
| - Global notification preferences (Cloud settings) are respected for design owners and can be used to disable notifications entirely | ||
Bhumikagarggg marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
Bhumikagarggg marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| - Thread-level muting does not suppress notifications for design owners | ||
|
|
||
| Tag other users and have them receive notification of your comment by mentioning their username with the `@` symbol. | ||
|
|
||
| All users participating in a comment will be notified as new remarks are added in a comment thread. | ||
|
|
||
| As new comments are added into the your design, collaborators (other users) with which you have shared the design, will not receive notification unless they are tagged in that comment. | ||
| As new comments are added into your design, collaborators (other users) with which you have shared the design, will not receive notification unless they are tagged in that comment. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "your" is active voice. Excellent. |
||
|
|
||
| ### Enable Email Notifications | ||
|
|
||
|
|
@@ -215,13 +221,19 @@ Customize your [notification preferences](/cloud/identity/users/notification-pre | |
|
|
||
| Customize your notification preferences to mute email notifications for comments on your design. With notifications for new comments silenced, you won't receive email notifications for new comments on your design. This can be useful if you want to temporarily pause notifications or reduce email clutter. | ||
|
|
||
| **Note:** | ||
Bhumikagarggg marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| - Thread-level muting does not suppress notifications for design owners | ||
|
|
||
| <figure> | ||
| <img src="./comment-notificationBell.png" alt="Turn Off notification from comments in designer" style="width:auto"> | ||
| <figcaption>Example of comments in Designer</figcaption> | ||
| </figure> | ||
|
|
||
| You can also manage all your comment notification settings centrally through the **Cloud -> Account -> [Preference](https://docs.layer5.io/cloud/identity/users/notification-preferences/)**. | ||
|
|
||
| **Note:** | ||
| - Global notification preferences (Cloud settings) are respected for design owners and can be used to disable notifications entirely | ||
|
|
||
| <figure> | ||
| <img src="./comment-cloud-manage.png" alt="Manage comment notifications in the Cloud Portal" style="width:auto"> | ||
| <figcaption>Manage all comment notifications centrally in the Cloud</figcaption> | ||
|
|
@@ -235,15 +247,18 @@ You can also manage all your comment notification settings centrally through the | |
| #### What Muting Doesn't Affect | ||
|
|
||
| - **Mentions in Other Designs:** You'll still be notified if someone mentions you in new or existing comment threads on other designs in your portfolio. | ||
| - **New Comment Threads:** Muting only applies to the specific comment thread it's activated on. New threads on the same design will trigger notifications as usual. | ||
| - **New Comment Threads:** Muting applies only to the specific thread where it is activated. | ||
| New threads on the same design follow the standard notification rules: | ||
| - Design owners will receive notifications | ||
| - Users will receive notifications only if they are participants in the thread or are explicitly mentioned | ||
|
|
||
| {{< alert title="Muted Notifcations Reminder">}} | ||
| {{< alert title="Muted Notifications Reminder">}} | ||
|
|
||
| - While email alerts are muted, you can still access and view all comments on the design at any time. | ||
| - You'll never miss an important mention, as notifications for mentions outside the muted thread remain active. | ||
| {{< /alert >}} | ||
|
|
||
| {{< alert type="info" title="Missed Notifcations">}} | ||
| {{< alert type="info" title="Missed Notifications">}} | ||
| Kanvas does not track the read or unread status of messages inside comment threads for each user. If a user is mentioned, but misses the notification, they might not become aware of the comment until they receive a new notification for another comment in that conversation. | ||
| {{< /alert >}} | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Single sentence paragraphs aren't ideal.