Skip to content

Embedded the design for k8s workshop #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Embedded the design for k8s workshop #144

wants to merge 20 commits into from

Conversation

ARYANSHAH1567
Copy link
Contributor

@ARYANSHAH1567 ARYANSHAH1567 commented Jul 26, 2025 •
edited
Loading

Notes for Reviewers

Embeds the design from #47 , #50

Signed commits

  • Yes, I signed my commits.

@leecalcote
Copy link
Member

Yay!

vr-varad
vr-varad reviewed Jul 28, 2025
View reviewed changes
Copy link
Collaborator

@vr-varad vr-varad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ARYANSHAH1567 but I think the id for meshery-design-embed should be in form embeded-design-<design-id> to maintain consistency across all the embeddings.

@ARYANSHAH1567
Copy link
Contributor Author

@vr-varad i think it should be fine now, i have updated the id from the url one

@ARYANSHAH1567 ARYANSHAH1567 requested a review from vr-varad July 28, 2025 11:54
@ARYANSHAH1567
Update _index.md
531e56a 
Signed-off-by: Aryan Shah <[email protected]>
vr-varad
vr-varad previously approved these changes Jul 28, 2025
View reviewed changes
@vr-varad
Copy link
Collaborator

Mind sharing ss or video? @ARYANSHAH1567

@ARYANSHAH1567
Copy link
Contributor Author

Mind sharing ss or video? @ARYANSHAH1567

I am currently having issues setting up hugo on my system

@vr-varad
Copy link
Collaborator

vr-varad commented Jul 29, 2025 •
edited
Loading

@ARYANSHAH1567 There is a merge conflict plus any visual representation would be helpful.
If you are facing any issue feel free to contact over slack.

@ARYANSHAH1567
Copy link
Contributor Author

Okay! I will update the pr by today

@ARYANSHAH1567
Fixed build error
ddb2794 
Signed-off-by: Aryan Shah <[email protected]>
@ARYANSHAH1567
Copy link
Contributor Author

ARYANSHAH1567 commented Jul 31, 2025 •
edited
Loading

image image

@ARYANSHAH1567 ARYANSHAH1567 requested a review from vr-varad July 31, 2025 15:12
@ARYANSHAH1567
Copy link
Contributor Author

@vr-varad @Namanv0509 I have embedded the design can you review it once please

Namanv0509
Namanv0509 previously approved these changes Aug 3, 2025
View reviewed changes
@ARYANSHAH1567
Copy link
Contributor Author

@vr-varad any updates on this pr?

@ARYANSHAH1567
Update _index.md
a7f5cf4 
Signed-off-by: Aryan Shah <[email protected]>
@marblom007
Copy link
Contributor

There are merge conflicts here...

@ARYANSHAH1567
Fixed merge conflict
a37eeb2 
Signed-off-by: Aryan Shah <[email protected]>
@ARYANSHAH1567
Copy link
Contributor Author

@marblom007 I have resolved the merge conflicts, can you please review the PR once

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Namanv0509 Namanv0509 Namanv0509 left review comments

@vr-varad vr-varad Awaiting requested review from vr-varad

@leecalcote leecalcote Awaiting requested review from leecalcote

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
academy area/challenges area/learning-paths exoscale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ARYANSHAH1567 @leecalcote @vr-varad @marblom007 @Namanv0509