Embedding [don't review yet] #262
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ranit Mukherjee <[email protected]>
RanitMukherjee
had a problem deploying
to
pr-preview-262
GitHub Actions
Error
RanitMukherjee
had a problem deploying
to
pr-preview-262
GitHub Actions
Failure
Signed-off-by: Ranit Mukherjee <[email protected]>
RanitMukherjee
had a problem deploying
to
pr-preview-262
GitHub Actions
Error
RanitMukherjee
had a problem deploying
to
pr-preview-262
GitHub Actions
Failure
Signed-off-by: Ranit Mukherjee <[email protected]>
RanitMukherjee
had a problem deploying
to
pr-preview-262
GitHub Actions
Error
RanitMukherjee
had a problem deploying
to
pr-preview-262
GitHub Actions
Failure
|
Is this PR "still don't review yet"? |
@leecalcote Unfortunately it is, I have played around quite a bit with lock/unlock to make the embedding consistent but yet to no avail, not sure if it's some issue in Kanvas (or maybe something browser-specific). |
|
Then, take a new approach…. |
|
Or unassign yourself from the issue and let another contributor carry it forward. |
Should be gtg once, layer5labs/meshery-extensions-packages#513 been handled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
Design: https://playground.meshery.io/extension/meshmap?mode=design&design=7191dfdd-2c44-4235-acb7-688f5e99750d
Embedding:
This PR fixes #172
Signed commits