Skip to content

Conversation

hargunkaur286
Copy link
Member

@hargunkaur286 hargunkaur286 commented Jun 26, 2024

Description

This PR fixes #5595

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Hargun Kaur <[email protected]>
@l5io
Copy link
Contributor

l5io commented Jun 26, 2024

🚀 Preview for commit 53db506 at: https://667c97532ed1181c1f160a91--layer5.netlify.app

@ashparshp
Copy link
Contributor

Screenshot (10)
Screenshot (11)

These two logos are getting too small. Please adjust the size so they maintain a consistent appearance and don't look out of place.

Copy link
Contributor

@ashparshp ashparshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logos under "Layer5 Social Backgrounds" and "Five, our mascot" are too small and need to be adjusted.

@iArchitSharma
Copy link
Contributor

@hargunkaur286 Thank you for your contribution.
Let's discuss this on Websites's call. Add this as an agenda item into the meeting minutes, if you would :)

margin-left: 0px;
}
.ImgDiv img{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how you are ensuring using this css that the image will set its dimensions accordingly based on screen size

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please review now? @sudhanshutech @iArchitSharma I have set the width to be auto so that it gets adjusted to different screen sizes and rather set the height.

Signed-off-by: Hargun Kaur <[email protected]>
@l5io
Copy link
Contributor

l5io commented Jul 5, 2024

🚀 Preview for commit 4fce6a5 at: https://668847deabe78a72ecb44df0--layer5.netlify.app

@ashparshp ashparshp requested a review from sudhanshutech July 9, 2024 08:08
@leecalcote leecalcote requested a review from ashparshp July 20, 2024 22:49
@leecalcote
Copy link
Member

@ashparshp what do you think? Good to go now or more feedback needed?

Copy link
Contributor

@ashparshp ashparshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leecalcote looks great and is ready to go. Thanks, @hargunkaur286, for making the changes!

@leecalcote leecalcote merged commit 39adfd6 into layer5io:master Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icons size too big for small screens
6 participants