Skip to content

Conversation

Namanv0509
Copy link
Member

Description

This PR fixes #
Before
image
After
image

This PR updates the Sistent Identity Color code page with the html table .

Notes for Reviewers
Need a review on UI and colors for table

the constant.dark theme doesnt exist for sistent , but was mentioned on website , what should i do for it

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Jul 5, 2025

🚀 Preview for commit c0ba21a at: https://686960f0fab5ec85c69c0d54--layer5.netlify.app

@vr-varad
Copy link
Contributor

vr-varad commented Jul 5, 2025

How about using this table on repository overview in https://layer5.io/community/handbook/repository-overview @Namanv0509
image

@Namanv0509
Copy link
Member Author

Namanv0509 commented Jul 5, 2025

How about using this table on repository overview in https://layer5.io/community/handbook/repository-overview @Namanv0509 image

Okay yes good suggestion , let me see

Copy link
Contributor

@Ayushmore1214 Ayushmore1214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Namanv0509 while working on this table https://layer5.io/community/handbook/repository-overview as requested from @vr-varad be sure that there is a problem related to this table while toggling in dark and light mode , here it is : #6581

@Namanv0509
Copy link
Member Author

@Namanv0509 while working on this table https://layer5.io/community/handbook/repository-overview as requested from @vr-varad be sure that there is a problem related to this table while toggling in dark and light mode , here it is : #6581

Yes i was encoutering same , thanks a lot for getting me aware.

If i can find a solution to it , i will ping you on slack.

@M-DEV-1
Copy link
Member

M-DEV-1 commented Jul 6, 2025

How about using this table on repository overview in https://layer5.io/community/handbook/repository-overview @Namanv0509 image

@vr-varad @Namanv0509

https://github.com/layer5io/layer5/blob/master/src/sections/Community/Handbook/repository.js

this uses simple html, and js to map out the contents.

This is one option, but here you're using Sistent, which is great and much more preferred

{col.token}
</StyledTableCell>
<StyledTableCell align="center">
<PreviewBox bgcolor={col.hex} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Namanv0509, could you implement a "copy" feature here for people to directly copy these colors, as they need?

This could be a separate column, or an extension to the preview box, on hover.

Copy link
Member Author

@Namanv0509 Namanv0509 Jul 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@M-DEV-1 Yeah sure , should i keep it "click text to copy" or a button which will be revealed on hover

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A separate button is better, in my opinion, but we can take a moment to discuss in today's meeting

Comment on lines 485 to 491
const StyledTableCell = styled(TableCell)(({ theme }) => ({
color: theme.palette.text.secondary,
fontSize: "0.875rem",
padding: "0.75rem",
borderBottom: `1px solid ${theme.palette.divider}`,
}));

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you could, it'd be nice to have the alternating theme like in the tables on

https://layer5.io/community/handbook/repository-overview

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

just a suggestion, but rounded borders would be nice, what do you say?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem i faced with alternating theme is that , some preview colors become almost hidden with it .
Any suggestion what color would be best for the even cells .

also yes i think boxes cane a bit more rounded . Thanks @M-DEV-1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the header cell to a darker color, like background.default and use the same, OR use background.secondary/tertiary

@Namanv0509
Copy link
Member Author

How about using this table on repository overview in https://layer5.io/community/handbook/repository-overview @Namanv0509 image

@vr-varad @Namanv0509

https://github.com/layer5io/layer5/blob/master/src/sections/Community/Handbook/repository.js

this uses simple html, and js to map out the contents.

This is one option, but here you're using Sistent, which is great and much more preferred

Yes , also the issue which is with Handbook.style.js i am thinking to use sistent for now .

@l5io
Copy link
Contributor

l5io commented Jul 6, 2025

🚀 Preview for commit 58c23dd at: https://686b0175d58168eda575b3b1--layer5.netlify.app

@leecalcote
Copy link
Member

If this work is complete, this is a good item to add to the weekly Websites meeting agenda. You can add this item in the doc, attend, and present it. Meeting details at https://meet.layer5.io.

}));

const StyledHeaderCell = styled(StyledTableCell)({
fontWeight: 600,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
fontWeight: 600,
fontWeight: 600,
color: theme.palette.background.default,

this way the header cell is charcoal[100], you can use secondary or tertiary for the alternating cells then

Experiment with these a bit, you'll find the right tones @Namanv0509

Comment on lines 485 to 491
const StyledTableCell = styled(TableCell)(({ theme }) => ({
color: theme.palette.text.secondary,
fontSize: "0.875rem",
padding: "0.75rem",
borderBottom: `1px solid ${theme.palette.divider}`,
}));

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the header cell to a darker color, like background.default and use the same, OR use background.secondary/tertiary

Copy link
Member

@sudhanshutech sudhanshutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be good to have copy icon to directly copy the color code @Namanv0509

Signed-off-by: Namanv0509 <[email protected]>
@l5io
Copy link
Contributor

l5io commented Jul 7, 2025

🚀 Preview for commit abda639 at: https://686b7b3d1d2a20e06c9f0cdf--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Jul 7, 2025

🚀 Preview for commit 1639d96 at: https://686b8171d9eff36a4b8ec7f3--layer5.netlify.app

Signed-off-by: Naman Verma <[email protected]>
@l5io
Copy link
Contributor

l5io commented Jul 7, 2025

🚀 Preview for commit 27eb972 at: https://686b85c574ef2709a435a91f--layer5.netlify.app

@Namanv0509
Copy link
Member Author

it would be good to have copy icon to directly copy the color code @Namanv0509

Sure , was thinking to use the Sistent icons for it

Signed-off-by: Naman Verma <[email protected]>
@l5io
Copy link
Contributor

l5io commented Jul 7, 2025

🚀 Preview for commit b394226 at: https://686bb16a0e652590838b8c8a--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Jul 8, 2025

🚀 Preview for commit 312afd8 at: https://686cc5ffab1426c62d4caaba--layer5.netlify.app

@vr-varad vr-varad merged commit df4eb6a into layer5io:master Jul 8, 2025
5 checks passed
@vr-varad
Copy link
Contributor

vr-varad commented Jul 8, 2025

Thanks @Namanv0509 for your contribution.

@Namanv0509
Copy link
Member Author

Thanks @vr-varad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants