-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Sistent identity Color update #6610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Namanv0509 <[email protected]>
Signed-off-by: Namanv0509 <[email protected]>
Signed-off-by: Namanv0509 <[email protected]>
🚀 Preview for commit c0ba21a at: https://686960f0fab5ec85c69c0d54--layer5.netlify.app |
How about using this table on repository overview in https://layer5.io/community/handbook/repository-overview @Namanv0509 |
Okay yes good suggestion , let me see |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Namanv0509 while working on this table https://layer5.io/community/handbook/repository-overview as requested from @vr-varad be sure that there is a problem related to this table while toggling in dark and light mode , here it is : #6581
Yes i was encoutering same , thanks a lot for getting me aware. If i can find a solution to it , i will ping you on slack. |
https://github.com/layer5io/layer5/blob/master/src/sections/Community/Handbook/repository.js this uses simple html, and js to map out the contents. This is one option, but here you're using Sistent, which is great and much more preferred |
{col.token} | ||
</StyledTableCell> | ||
<StyledTableCell align="center"> | ||
<PreviewBox bgcolor={col.hex} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Namanv0509, could you implement a "copy" feature here for people to directly copy these colors, as they need?
This could be a separate column, or an extension to the preview box, on hover.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@M-DEV-1 Yeah sure , should i keep it "click text to copy" or a button which will be revealed on hover
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A separate button is better, in my opinion, but we can take a moment to discuss in today's meeting
const StyledTableCell = styled(TableCell)(({ theme }) => ({ | ||
color: theme.palette.text.secondary, | ||
fontSize: "0.875rem", | ||
padding: "0.75rem", | ||
borderBottom: `1px solid ${theme.palette.divider}`, | ||
})); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you could, it'd be nice to have the alternating theme like in the tables on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem i faced with alternating theme is that , some preview colors become almost hidden with it .
Any suggestion what color would be best for the even cells .
also yes i think boxes cane a bit more rounded . Thanks @M-DEV-1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the header cell to a darker color, like background.default
and use the same, OR use background.secondary/tertiary
Yes , also the issue which is with Handbook.style.js i am thinking to use sistent for now . |
Signed-off-by: Namanv0509 <[email protected]>
🚀 Preview for commit 58c23dd at: https://686b0175d58168eda575b3b1--layer5.netlify.app |
If this work is complete, this is a good item to add to the weekly Websites meeting agenda. You can add this item in the doc, attend, and present it. Meeting details at https://meet.layer5.io. |
})); | ||
|
||
const StyledHeaderCell = styled(StyledTableCell)({ | ||
fontWeight: 600, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fontWeight: 600, | |
fontWeight: 600, | |
color: theme.palette.background.default, |
this way the header cell is charcoal[100]
, you can use secondary
or tertiary
for the alternating cells then
Experiment with these a bit, you'll find the right tones @Namanv0509
const StyledTableCell = styled(TableCell)(({ theme }) => ({ | ||
color: theme.palette.text.secondary, | ||
fontSize: "0.875rem", | ||
padding: "0.75rem", | ||
borderBottom: `1px solid ${theme.palette.divider}`, | ||
})); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the header cell to a darker color, like background.default
and use the same, OR use background.secondary/tertiary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be good to have copy icon to directly copy the color code @Namanv0509
Signed-off-by: Namanv0509 <[email protected]>
🚀 Preview for commit abda639 at: https://686b7b3d1d2a20e06c9f0cdf--layer5.netlify.app |
Signed-off-by: Namanv0509 <[email protected]>
…09/layer5 into sistent_identity_update
🚀 Preview for commit 1639d96 at: https://686b8171d9eff36a4b8ec7f3--layer5.netlify.app |
Signed-off-by: Naman Verma <[email protected]>
🚀 Preview for commit 27eb972 at: https://686b85c574ef2709a435a91f--layer5.netlify.app |
Sure , was thinking to use the Sistent icons for it |
Signed-off-by: Naman Verma <[email protected]>
🚀 Preview for commit b394226 at: https://686bb16a0e652590838b8c8a--layer5.netlify.app |
Signed-off-by: Namanv0509 <[email protected]>
🚀 Preview for commit 312afd8 at: https://686cc5ffab1426c62d4caaba--layer5.netlify.app |
Thanks @Namanv0509 for your contribution. |
Thanks @vr-varad |
Description
This PR fixes #


Before
After
This PR updates the Sistent Identity Color code page with the html table .
Notes for Reviewers
Need a review on UI and colors for table
the constant.dark theme doesnt exist for sistent , but was mentioned on website , what should i do for it
Signed commits