Skip to content

Handbook Table Theme Fix #6612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Handbook Table Theme Fix #6612

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d743dc5
Handbook Table Theme Fix
Namanv0509 Jul 7, 2025
d814cb7
Handbook Table Theme Fix
Namanv0509 Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/sections/Community/Handbook/Handbook.style.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ export const HandbookWrapper = styled.div`
}

td, th {
border: 0.05rem solid ${(props) => props.theme.primaryLightColor};
Copy link
Contributor

@vr-varad vr-varad Jul 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Namanv0509 I don't this the error is with td, th.
The error is with tbody, and if u look up the inspect u might find this
image
so any other CSS is overlapping and that might me the issue

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes i was skeptical on it , will try to find the overlapping. Thanks @vr-varad

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh with the td tb , when i was toggling theme , the border colors also had an issue i found and not only the cells , thats why i changed that too . @vr-varad

border: 0.05rem solid ${(props) => props.theme.primaryTestLightColor};
text-align: left;
padding: 0.5rem;
transition: 0.8s cubic-bezier(0.2, 0.8, 0.2, 1);
Expand All @@ -180,7 +180,7 @@ export const HandbookWrapper = styled.div`
}

tbody:nth-child(even) {
background-color: ${(props) => props.theme.secondaryLightColorTwo};
background-color: ${(props) => props.theme.secondaryTestLightColorTwo};
transition: 0.8s cubic-bezier(0.2, 0.8, 0.2, 1);
}

Expand Down
6 changes: 4 additions & 2 deletions src/theme/app/themeStyles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ const lighttheme = {

// silver chalice (light gray)
primaryLightColor: "#b3b3b3",
primaryTestLightColor: "#2C2C2C",

// keppel (dark green)
primaryLightColorTwo: "#00d3a9",
Expand All @@ -24,6 +25,7 @@ const lighttheme = {
secondaryColor: "#00b39f",
caribbeanGreenColor: "#00d3a9",
secondaryLightColorTwo: "#F3FFFD",
secondaryTestLightColorTwo: "rgba(0,179,159, .4)",

// lighter gray
secondaryLightColor: "#FAFAFA",
Expand Down Expand Up @@ -248,7 +250,7 @@ export const darktheme = {

// silver chalice (light gray)
primaryLightColor: "#2C2C2C",

primaryTestLightColor: "#2C2C2C",
// keppel (dark green)
primaryLightColorTwo: "#2C2C2C",
keppelColor: "#00d3a9",
Expand All @@ -257,7 +259,7 @@ export const darktheme = {
secondaryColor: "#00b39f",
caribbeanGreenColor: "#00d3a9",
secondaryLightColorTwo: "rgba(0,179,159, .4)",

secondaryTestLightColorTwo: "rgba(0,179,159, .4)",
// lighter gray
secondaryLightColor: "#000000",

Expand Down
Loading