Skip to content

fixed input text code section #6625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

ARYANSHAH1567
Copy link
Contributor

@ARYANSHAH1567 ARYANSHAH1567 commented Jul 11, 2025

Description

This PR fixes #6331

Notes for Reviewers

I have Added a max-width for the sidebar and allowng a vertical scrolling feature, Also the text-input's code section which earlier showed "Sorry this page is still under work" has been replaced with the neccessary code

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Jul 11, 2025

🚀 Preview for commit 65cec2d at: https://687130b9d1c0f917a74ae999--layer5.netlify.app

@vr-varad
Copy link
Contributor

I guess there are 2 part of issue and i don't know which one u have resolved. @ARYANSHAH1567

@ARYANSHAH1567
Copy link
Contributor Author

I guess there are 2 part of issue and i don't know which one u have resolved. @ARYANSHAH1567

My bad, i didnt intercept the issue correctly, will fix one of the two issues and update the pr, Can u please tell me what text has to be added in the Code section of text-input because its currently showing "Sorry this page is still under work"

@vr-varad
Copy link
Contributor

U have answered ur own question. @ARYANSHAH1567

Copy link
Contributor

@Ayushmore1214 Ayushmore1214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the code block you can refer this : #6541 @ARYANSHAH1567

@vr-varad
Copy link
Contributor

@ARYANSHAH1567
Thank you for your contribution!
Let's discuss this during the website call today at 5:30 PM IST | 7 AM CT

Add it as an agenda item to the meeting minutes, if you would :)

@l5io
Copy link
Contributor

l5io commented Jul 14, 2025

🚀 Preview for commit f1a001b at: https://6874baf313bcbdd9d6eba3a1--layer5.netlify.app

Signed-off-by: Aryan Shah <[email protected]>
@l5io
Copy link
Contributor

l5io commented Jul 14, 2025

🚀 Preview for commit b35acbe at: https://6874df2a0f821a9ba62aff3a--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Jul 14, 2025

🚀 Preview for commit 43991dd at: https://68754d5d51c69f8cf1d1b599--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Jul 14, 2025

🚀 Preview for commit c4cd765 at: https://6875530b51c69fa143d1b27e--layer5.netlify.app

@ARYANSHAH1567
Copy link
Contributor Author

@vr-varad @leecalcote Can u review the PR? i have completed the code section for text input, u can see it at
https://6875530b51c69fa143d1b27e--layer5.netlify.app/projects/sistent/components/text-input/code

@vr-varad
Copy link
Contributor

@ARYANSHAH1567 follow this pr #6605

@leecalcote leecalcote requested a review from vr-varad July 16, 2025 15:58
@ARYANSHAH1567
Copy link
Contributor Author

@ARYANSHAH1567 follow this pr #6605

Hey @vr-varad,
I've aligned the code.js structure with the PR example you referenced. The file maintains the showcase format with CodeBlock components for each variant. If there are specific aspects that need further adjustment, please let me know which sections to focus on. Can u review it once

@LibenHailu
Copy link
Contributor

LGTM

Signed-off-by: Aryan Shah <[email protected]>
@ARYANSHAH1567 ARYANSHAH1567 requested a review from vr-varad July 25, 2025 17:27
@l5io
Copy link
Contributor

l5io commented Jul 25, 2025

🚀 Preview for commit c8f9197 at: https://6883c133f7d4b69697968ced--layer5.netlify.app

Copy link
Contributor

@vr-varad vr-varad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. There is still repetitive text in both overview and code.
  2. There is no parameter as size in Input. ref1 ref2 that is why there is no difference in all 3 input boxes.
    @ARYANSHAH1567 mind changing it in all 3 sections and adding appropriate use case and code?

@ARYANSHAH1567
Copy link
Contributor Author

  1. There is still repetitive text in both overview and code.
  2. There is no parameter as size in Input. ref that is why there is no difference in all 3 input boxes.
    @ARYANSHAH1567 mind changing it in all 3 sections?

Yeah okay, i will look to complete it and fix it in all three sections

@vr-varad
Copy link
Contributor

Thank you for your contribution!
Let's discuss this during the website call today at 5:30 PM IST | 7 AM CT

Add it as an agenda item to the meeting minutes, if you would :)

@l5io
Copy link
Contributor

l5io commented Jul 28, 2025

🚀 Preview for commit 12b54e9 at: https://68870cb7381546d1b73e38c0--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Aug 3, 2025

🚀 Preview for commit e2acba5 at: https://688ef241a869ce561223c5a7--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Aug 3, 2025

🚀 Preview for commit 7cf8588 at: https://688f04209921b284b79fb5f4--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Aug 9, 2025

🚀 Preview for commit 7c74207 at: https://6896f6d8245eab21f86476b9--layer5.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Text Input Code Section & Enable Scrolling in Component Sidebar
6 participants