-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[Program.style.js] Fixed the scaling issues on internship programs page #6630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Shirshendu R Tripathi <[email protected]>
🚀 Preview for commit bee2578 at: https://68749ccd9073d07e242875be--layer5.netlify.app |
@ShirshenduR Add it as an agenda item to the meeting minutes, if you would :) |
🚀 Preview for commit 64b09c0 at: https://6875df1d422906155f5f484e--layer5.netlify.app |
@@ -5,11 +5,16 @@ export const ProgramsWrapper = styled.div` | |||
color: ${props => props.theme.keppelColor}; | |||
overflow-wrap: break-word; | |||
} | |||
div[style*="aspect-ratio"] { | |||
aspect-ratio: unset !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't use !important
@ShirshenduR
@@ -28,7 +28,7 @@ Prepare for Hacktoberfest and ready yourself for contributing to CNCF projects t | |||
|
|||
<h3>Earn a Badge </h3> | |||
<p>Earn a Hacktoberfest Contributor badge by contributing to Layer5 projects during this Hacktoberfest.</p> | |||
<img src={hacktoberfestBadge} style="width: 250px"/> | |||
<img src={hacktoberfestBadge} style="width: 250px; aspect-ratio: unset !important;"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here as well
img{ | ||
width: 19vw; | ||
float: right; | ||
margin-left: 40px; | ||
margin-bottom: 30px; | ||
aspect-ratio: unset !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here as well
🚀 Preview for commit 416ce47 at: https://6877c599a6e2e50bd30237a3--layer5.netlify.app |
Had a question @ShirshenduR why use !important ?? |
@ShirshenduR Add it as an agenda item to the meeting minutes, if you would :) |
@vr-varad actually I am not well that's why I was inactive I will fix it and present next week. |
Description
This PR fixes #6619
Notes for Reviewers
@vr-varad please review
Signed commits