-
Notifications
You must be signed in to change notification settings - Fork 1.4k
FIX : added max-width to images on learnign-paths #6411 #6645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: HIMANSHU RAI <[email protected]>
🚀 Preview for commit 833f8a4 at: https://687d17f55032378c69e9ef5e--layer5.netlify.app |
Signed-off-by: HIMANSHU RAI <[email protected]>
🚀 Preview for commit f8b0b4f at: https://687d2fa8a90e37f285f0657a--layer5.netlify.app |
Hi @HIMU-2001, Thank you for the efforts. Do you mind providing us with before and after screenshots? |
@LibenHailu Sure. After : ![]() ![]() |
Hi @HIMU-2001 , Thank you for providing the screen shorts. Can you remove {" "}? It is just right below the second image, and we usually go with a centered approach for images with max width. |
Signed-off-by: HIMANSHU RAI <[email protected]>
🚀 Preview for commit 09fdfe0 at: https://687dc9fd4115fbdd8fa70010--layer5.netlify.app |
@HIMU-2001 Add it as an agenda item to the meeting minutes, if you would :) |
Hi @LibenHailu , As per your inputs, I have made the modifications & it currently looks like this : ![]() |
LGTM @HIMU-2001 |
Hi @vr-varad , Any inputs on this. |
![]() |
🚀 Preview for commit 7155bd8 at: https://68824bdab6eb55fd73a7bc00--layer5.netlify.app |
Signed-off-by: HIMANSHU RAI <[email protected]>
🚀 Preview for commit aa9cfcb at: https://6885a1ba901658085bdb4afd--layer5.netlify.app |
Hi @vr-varad , I have fixed the alignment for the specified image. |
🚀 Preview for commit 747692b at: https://68870ce67774719c95c0ffe4--layer5.netlify.app |
Description
This PR fixes #6411
Notes for Reviewers
Signed commits