Skip to content

FIX : added max-width to images on learnign-paths #6411 #6645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

HIMU-2001
Copy link

Description

This PR fixes #6411

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: HIMANSHU RAI <[email protected]>
@l5io
Copy link
Contributor

l5io commented Jul 20, 2025

🚀 Preview for commit 833f8a4 at: https://687d17f55032378c69e9ef5e--layer5.netlify.app

Signed-off-by: HIMANSHU RAI <[email protected]>
@l5io
Copy link
Contributor

l5io commented Jul 20, 2025

🚀 Preview for commit f8b0b4f at: https://687d2fa8a90e37f285f0657a--layer5.netlify.app

@LibenHailu
Copy link
Contributor

Hi @HIMU-2001, Thank you for the efforts. Do you mind providing us with before and after screenshots?

@HIMU-2001
Copy link
Author

@LibenHailu Sure.

Before :
image
image

After :

image image

@LibenHailu
Copy link
Contributor

Hi @HIMU-2001 , Thank you for providing the screen shorts. Can you remove {" "}? It is just right below the second image, and we usually go with a centered approach for images with max width.

Signed-off-by: HIMANSHU RAI <[email protected]>
@l5io
Copy link
Contributor

l5io commented Jul 21, 2025

🚀 Preview for commit 09fdfe0 at: https://687dc9fd4115fbdd8fa70010--layer5.netlify.app

@vr-varad
Copy link
Contributor

@HIMU-2001
Thank you for your contribution!
Let's discuss this during the website call today at 5:30 PM IST | 7 AM CT

Add it as an agenda item to the meeting minutes, if you would :)

@HIMU-2001
Copy link
Author

Hi @LibenHailu ,

As per your inputs, I have made the modifications & it currently looks like this :

image

@LibenHailu
Copy link
Contributor

LGTM @HIMU-2001

@HIMU-2001
Copy link
Author

Hi @vr-varad ,

Any inputs on this.

@LibenHailu LibenHailu requested a review from vr-varad July 24, 2025 14:34
@vr-varad
Copy link
Contributor

vr-varad commented Jul 24, 2025

image This image looks misaligned @HIMU-2001

@l5io
Copy link
Contributor

l5io commented Jul 24, 2025

🚀 Preview for commit 7155bd8 at: https://68824bdab6eb55fd73a7bc00--layer5.netlify.app

Signed-off-by: HIMANSHU RAI <[email protected]>
@l5io
Copy link
Contributor

l5io commented Jul 27, 2025

🚀 Preview for commit aa9cfcb at: https://6885a1ba901658085bdb4afd--layer5.netlify.app

@HIMU-2001
Copy link
Author

Hi @vr-varad ,

I have fixed the alignment for the specified image.
Reference Screenshot :
image

@l5io
Copy link
Contributor

l5io commented Jul 28, 2025

🚀 Preview for commit 747692b at: https://68870ce67774719c95c0ffe4--layer5.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add max-width to images on learnign-paths
4 participants