Skip to content

Publish avatar and avarat group component #6655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

LibenHailu
Copy link
Contributor

Description

This PR fixes #6189

Notes for Reviewers

This PR builds upon the previously raised PRs, addresses the feedback provided, and adds the missing components.

#6221
#6259

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Jul 23, 2025

🚀 Preview for commit b891d4c at: https://68812f4b4cb43daae40ca729--layer5.netlify.app

@LibenHailu LibenHailu requested a review from vr-varad July 24, 2025 14:30
Copy link
Contributor

@vr-varad vr-varad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image Mind adding these code snippets in code blocks? @LibenHailu

@LibenHailu
Copy link
Contributor Author

Mind adding these c

Sure, I used the previous PRs and didn’t see any comments regarding this, but it makes sense to move it into the code block. The Guidance section should focus solely on best practices and guidelines. I’ll update the change. @vr-varad

@vr-varad
Copy link
Contributor

Thank you for your contribution!
Let's discuss this during the website call today at 5:30 PM IST | 7 AM CT

Add it as an agenda item to the meeting minutes, if you would :)

@l5io
Copy link
Contributor

l5io commented Jul 28, 2025

🚀 Preview for commit 5ff569e at: https://68870cf924631c99c6f75736--layer5.netlify.app

@vr-varad
Copy link
Contributor

any progress on this @LibenHailu

@l5io
Copy link
Contributor

l5io commented Jul 31, 2025

🚀 Preview for commit 285bce2 at: https://688be820ea6db07ce839bfb7--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Aug 1, 2025

🚀 Preview for commit 6eca251 at: https://688cf32a76be913b02098421--layer5.netlify.app

@LibenHailu
Copy link
Contributor Author

LibenHailu commented Aug 1, 2025

Hi @vr-varad, apologies for the timing it shouldn't have taken this long. I have made the updates please feel free to re-review them.

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're good to go here, @LibenHailu.

@sudhanshutech, do you think so, too?

Copy link
Member

@sudhanshutech sudhanshutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LibenHailu why there is text inside the preview box, please move out from that. Looks very odd and else looks good
{B79BED29-7B0E-42E8-B6C0-65DCEA83336C}

@sudhanshutech
Copy link
Member

I think we're good to go here, @LibenHailu.

@sudhanshutech, do you think so, too?

just one change need a fix @leecalcote then good to go

@l5io
Copy link
Contributor

l5io commented Aug 5, 2025

🚀 Preview for commit 1864a61 at: https://6891b7d3a436e5f13395b984--layer5.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Projects] [Sistent] Publish Avatar and AvatarGroup as a components
5 participants