-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Publish avatar and avarat group component #6655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Publish avatar and avarat group component #6655
Conversation
Signed-off-by: Liben Hailu <[email protected]>
Signed-off-by: Liben Hailu <[email protected]>
Signed-off-by: Liben Hailu <[email protected]>
Signed-off-by: Liben Hailu <[email protected]>
Signed-off-by: Liben Hailu <[email protected]>
Signed-off-by: Liben Hailu <[email protected]>
Signed-off-by: Liben Hailu <[email protected]>
Signed-off-by: Liben Hailu <[email protected]>
Signed-off-by: Liben Hailu <[email protected]>
🚀 Preview for commit b891d4c at: https://68812f4b4cb43daae40ca729--layer5.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

Sure, I used the previous PRs and didn’t see any comments regarding this, but it makes sense to move it into the code block. The Guidance section should focus solely on best practices and guidelines. I’ll update the change. @vr-varad |
Thank you for your contribution! Add it as an agenda item to the meeting minutes, if you would :) |
🚀 Preview for commit 5ff569e at: https://68870cf924631c99c6f75736--layer5.netlify.app |
any progress on this @LibenHailu |
🚀 Preview for commit 285bce2 at: https://688be820ea6db07ce839bfb7--layer5.netlify.app |
Signed-off-by: Liben Hailu <[email protected]>
🚀 Preview for commit 6eca251 at: https://688cf32a76be913b02098421--layer5.netlify.app |
Hi @vr-varad, apologies for the timing it shouldn't have taken this long. I have made the updates please feel free to re-review them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're good to go here, @LibenHailu.
@sudhanshutech, do you think so, too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LibenHailu why there is text inside the preview box, please move out from that. Looks very odd and else looks good
just one change need a fix @leecalcote then good to go |
…lass Signed-off-by: Liben Hailu <[email protected]>
🚀 Preview for commit 1864a61 at: https://6891b7d3a436e5f13395b984--layer5.netlify.app |
Description
This PR fixes #6189
Notes for Reviewers
This PR builds upon the previously raised PRs, addresses the feedback provided, and adds the missing components.
#6221
#6259
Signed commits