Skip to content

Conversation

HarK-github
Copy link

@HarK-github HarK-github commented Jul 26, 2025

Fix: Description of the Fix

Description

This PR fixes 5640 by updating the responsive banner to work correctly with inline styles.
Reproduce issue: https://layer5.io/learn/service-mesh-labs/working-with-meshery-and-istio scale this doen

Notes for Reviewers

  • Adjusted the <div> with inline styles to ensure responsiveness on both small and large screens.

  • Used flex-wrap, white-space: nowrap, and padding for better layout behavior.

  • No additional dependencies or external CSS used — all inline for maximum compatibility.

  • Yes, I signed my commits.


Checklist Before Review

  • Build and tests pass.
  • Follows Layer5 contribution conventions.
  • Commit(s) are signed.

@HarK-github HarK-github changed the title Harkissue Updated the responsive banner to work correctly with inline styles Jul 26, 2025
@HarK-github
Copy link
Author

@vr-varad could you check this out. I have attached an image for the same
image

@vr-varad
Copy link
Contributor

I couldn't check as the checks are failing!! @HarK-github

@HarK-github
Copy link
Author

@vr-varad I am not able to pass the checks even though I changed nothing in dependencies. Only 8 files have been changed . Can you help.

@vr-varad
Copy link
Contributor

vr-varad commented Jul 26, 2025

  1. Your DCO is failing. fix
  2. The checks are failing because of this
/home/runner/work/layer5/layer5/src/collections/service-mesh-labs/working_with_meshery_and_kuma/index.mdx: incomplete explicit mapping pair; a key node is missed; or followed by a non-tabulated empty line at line 3, column 43:
     ... ="display: flex; justify-content: center; align-items: center; f ... 
                                         ^

@HarK-github

@l5io
Copy link
Contributor

l5io commented Jul 26, 2025

🚀 Preview for commit 65ad4a9 at: https://6885390473853d1886edc21b--layer5.netlify.app

@HarK-github
Copy link
Author

HarK-github commented Jul 26, 2025

@vr-varad done pls check.

@vr-varad
Copy link
Contributor

The DCO is still failing @HarK-github

@l5io
Copy link
Contributor

l5io commented Jul 27, 2025

🚀 Preview for commit d8fa1b3 at: https://688674aa6d69ea25ebece57c--layer5.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The text and layout need to be adjusted for better readability and usability across different screen sizes.
3 participants