Updated the responsive banner to work correctly with inline styles #6663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harshit Kandpal <[email protected]>
|
@vr-varad I have made this PR as previous one was broken. Now can you check. |
|
🚀 Preview for commit 4a6835d at: https://68867893ea9dd8ea983d0666--layer5.netlify.app |
|
Thank you for your contribution! Add it as an agenda item to the meeting minutes, if you would :) |
|
The fix was on text and layout for mobile screen , some of these changes are undesired . |
Namanv0509
reviewed
Jul 29, 2025
| Sign into the <a href="https://playground.meshery.io">Meshery Playground</a> (free account) to continue your lab. | ||
| <div style="display: flex; justify-content: center; align-items: center; flex-wrap: wrap; padding: 2rem 1rem; width: 100%; background-color: black; color: white; font-size: 1rem; text-align: center;"> | ||
| Sign into the | ||
| <a href="https://playground.meshery.io" target="_blank" rel="noopener noreferrer" style="color: #00bfff; text-decoration: underline; margin: 0 0.3rem; white-space: nowrap;"> |
There was a problem hiding this comment.
the hyperlink color shouldnt be hardcoded here .
There was a problem hiding this comment.
@Namanv0509 removed the hyperlink color style.
Signed-off-by: Harshit Kandpal <[email protected]>
|
🚀 Preview for commit 2e507b8 at: https://688a72d156098e7a5806ddd6--layer5.netlify.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Description of the Fix
Description
This PR fixes 5640 by updating the responsive banner to work correctly with inline styles.
Reproduce issue: https://layer5.io/learn/service-mesh-labs/working-with-meshery-and-istio scale this doen
Notes for Reviewers
Adjusted the
<div>with inline styles to ensure responsiveness on both small and large screens.Used
flex-wrap,white-space: nowrap, and padding for better layout behavior.No additional dependencies or external CSS used — all inline for maximum compatibility.
Yes, I signed my commits.
Checklist Before Review