-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Replace LearnServiceMeshCTA with KanvasCTA #6556 #6671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Replace LearnServiceMeshCTA with KanvasCTA #6556 #6671
Conversation
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
🚀 Preview for commit c869939 at: https://688c85e8202cdcae5559678e--layer5.netlify.app |
Thank you for your contribution! Add it as an agenda item to the meeting minutes, if you would :) |
@Rajesh-Nagarajan-11 offer a screenshot or hyperlink to a preview page with this new CTA. |
@leecalcote Updated in PR Description |
Thank you for contributing! LGTM! I noticed that one other file: src/templates/event-single.js still references LearnServiceMeshCTA. Could you update that one to KanvasCTA as well? I also noticed a couple of design inconsistencies:
Would you be able to fix these as well for consistency? |
@avni-mahajan Yeah thank you avni !! Event-single.js page already has another kanvas CTA checkout that and let me check with design inconsistency 👍🏻 |
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
@avni-mahajan Updated everthing what u suggested , Kindly review once ! thank Youu !! |
🚀 Preview for commit 4c98417 at: https://689172923493b6d65358696a--layer5.netlify.app |
Description
This PR fixes #6556
This PR updates the LearnServiceMeshCTA component to KanvasCTA across the following files:
1.subscribe.js
2.unsubscribe.js
3.unsubscribed.js
4.service-mesh-book.js
5.thank-you.js
All instances of LearnServiceMeshCTA have been replaced to align with the latest call-to-action direction.
Notes for Reviewers
Please check the preview pages to ensure the KanvasCTA is rendering properly:
1./thank-you
2./subscribe

3./unsubscribe
4./unsubscribed

5./learn/service-mesh-books

Signed commits