-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fix social media share links #6672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix social media share links #6672
Conversation
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
🚀 Preview for commit 4dccdc5 at: https://688cd24afd3c3c8ca79c4904--layer5.netlify.app |
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
🚀 Preview for commit 5f1e8e0 at: https://688ce0056ff7e3db902ea782--layer5.netlify.app |
@vr-varad LinkedIn and Facebook previews weren't generating earlier because the shared link was pointing to the Netlify deploy preview URL, which includes the x-robots-tag: noindex header. This prevents both platforms from crawling and generating previews. To resolve this, we need to use the production URL, which becomes available only after the PR is merged. The production URL doesn’t include the noindex directive, so LinkedIn and Facebook will be able to generate the preview correctly. Therefore, to fully verify the preview behavior on LinkedIn and Facebook, this PR needs to be merged |
Thank you for your contribution! Add it as an agenda item to the meeting minutes, if you would :) |
<AiOutlineTwitter /> | ||
</TwitterShareButton> | ||
<FacebookShareButton $url={location.href} quote={shareQuote} className="icon"> | ||
<FacebookShareButton url={location.href} quote={shareQuote || "Check out this article!"} className="icon"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the || "Check out this article!"
, please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed 👍🏻
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
@leecalcote Updated !! |
🚀 Preview for commit a1ed83f at: https://6890be440c667c0078075040--layer5.netlify.app |
Description
This PR fixes the non-functional social media share links in the blog author section by the react-share components .
This PR fixes #6396
Notes for Reviewers
Visit: /blog/docker/docker-model-runner-engineering-summary-future-horizons
Scroll down to the “Share Post” section.
Click on the LinkedIn, X (Twitter), or Facebook icons.
Signed commits