Skip to content

Added table component to typography code.js #6680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

avni-mahajan
Copy link

@avni-mahajan avni-mahajan commented Aug 4, 2025

Description
Replaced images previously used to display information in typography/code.js with the table component.
This ensures design consistency across sections like color/code.js and spacing/code.js, aligning the layout and visual presentation.
This PR fixes #6679

After:
Screenshot 2025-08-04 080535

Screenshot 2025-08-04 080544

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Aug 4, 2025

🚀 Preview for commit cc21c91 at: https://6890363b910bb1f7b321d52c--layer5.netlify.app

@vr-varad
Copy link
Contributor

vr-varad commented Aug 4, 2025

Thank you for your contribution!
Let's discuss this during the website call today at 5:30 PM IST | 7 AM CT

Add it as an agenda item to the meeting minutes, if you would :)

@l5io
Copy link
Contributor

l5io commented Aug 4, 2025

🚀 Preview for commit c156ae8 at: https://689057addadfdf0347aaaa9a--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Aug 4, 2025

🚀 Preview for commit 151a354 at: https://689067c5152c9470d3ed8a06--layer5.netlify.app

@Namanv0509
Copy link
Member

@avni-mahajan
6:10 warning 'Col' is defined but never used. Allowed unused vars must match /React/u no-unused-vars 6:15 warning 'Row' is defined but never used. Allowed unused vars must match /React/u no-unused-vars 274:1 error Expected indentation of 4 spaces but found 17 indent 275:1 error Expected indentation of 6 spaces but found 17 indent 391:1 error Trailing spaces not allowed no-trailing-spaces 434:1 error Trailing spaces not allowed no-trailing-spaces

there are unsued variables , indentation error at 274 and 275 line and trailing spaces at 391 and 434 .
Please resolve this , it will help resolving the failing check .

Also the DCO is failing , because you forgot to signoff last commit .

@vr-varad
Copy link
Contributor

vr-varad commented Aug 5, 2025

@avni-mahajan, could you mind fixing the checks and DCO error?

@l5io
Copy link
Contributor

l5io commented Aug 5, 2025

🚀 Preview for commit 60ab88b at: https://68927e894c70300d9cfa8aa5--layer5.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sistent Identity Typography Update
4 participants