Skip to content

fix: cta #7319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
KhushamBansal wants to merge 13 commits into
base: master
Choose a base branch
from
Open

fix: cta #7319

KhushamBansal wants to merge 13 commits into from
+26 −15

Conversation

@KhushamBansal
Copy link
Contributor

@KhushamBansal KhushamBansal commented Jan 3, 2026 •
edited by Rajesh-Nagarajan-11
Loading

Description

This PR fixes #7304

Notes for Reviewers
Fix: CTA FullWidth responsiveness on mobile devices

Signed commits

  • Yes, I signed my commits.

@KhushamBansal
fix: cta
ed157e0 
Signed-off-by: Khusham Bansal <[email protected]>
@KhushamBansal
Fix: build error
4b08d82 
Signed-off-by: Khusham Bansal <[email protected]>
@l5io
Copy link
Contributor

l5io commented Jan 3, 2026

🚀 Preview for commit 4b08d82 at: https://6958f7358870fdd41da4e8a8--layer5.netlify.app

@KhushamBansal
Fix: image
aa6acdc 
Signed-off-by: Khusham Bansal <[email protected]>
@l5io
Copy link
Contributor

l5io commented Jan 3, 2026

🚀 Preview for commit aa6acdc at: https://6958fd8db07f32a8709f25b7--layer5.netlify.app

@KhushamBansal
Copy link
Contributor Author

KhushamBansal commented Jan 3, 2026

Hi @kishore08-07 , can you review this?

@CodexRaunak
Copy link
Contributor

CodexRaunak commented Jan 3, 2026 •
edited
Loading

@KhushamBansal Thank you for your contribution! Let's discuss this during the website call on Monday at 6:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂

@KhushamBansal
Copy link
Contributor Author

KhushamBansal commented Jan 3, 2026 •
edited
Loading

@CodexRaunak , Thanks! I’ll add this as an agenda item for the upcoming Monday website call.

@l5io
Copy link
Contributor

l5io commented Jan 5, 2026

🚀 Preview for commit a8c67f0 at: https://695bc318aead7f8925929ab6--layer5.netlify.app

Rajesh-Nagarajan-11
Rajesh-Nagarajan-11 reviewed Jan 5, 2026
View reviewed changes
Copy link
Member

@Rajesh-Nagarajan-11 Rajesh-Nagarajan-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm your changes does't affect other CTA's

Rajesh-Nagarajan-11
Rajesh-Nagarajan-11 requested changes Jan 5, 2026
View reviewed changes
src/collections/programs/hacktoberfest-2023/index.mdx Outdated
type: Event
permalink: "hacktoberfest/2023"
program: "Hacktoberfest"
programSlug: "hacktoberfest"
Copy link
Member

@Rajesh-Nagarajan-11 Rajesh-Nagarajan-11 Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this changes

@l5io
Copy link
Contributor

l5io commented Jan 5, 2026

🚀 Preview for commit f772658 at: https://695bd1d81d1643ccf69713eb--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Jan 6, 2026

🚀 Preview for commit 7fe1533 at: https://695d142ce8b9d75310333dc3--layer5.netlify.app

kishore08-07
kishore08-07 reviewed Jan 7, 2026
View reviewed changes
Copy link
Contributor

@kishore08-07 kishore08-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KhushamBansal kindly attach before & after screenshots to ease the review process.

@kishore08-07
Copy link
Contributor

kishore08-07 commented Jan 7, 2026 •
edited
Loading

Please confirm your changes does't affect other CTA's

@KhushamBansal, as discussed in the websites meeting, please refer to:#7308 (comment)
Jeet has highlighted the other CTAs that are being affected there.

@KhushamBansal
Copy link
Contributor Author

KhushamBansal commented Jan 7, 2026

Sure , I'll confirm it by tomorrow.

@KhushamBansal
Copy link
Contributor Author

KhushamBansal commented Jan 7, 2026 •
edited
Loading

@kishore08-07
Also, can you check that if the CTA looks fine in mobile view?

@kishore08-07
Copy link
Contributor

kishore08-07 commented Jan 7, 2026

@KhushamBansal kindly attach before & after screenshots to ease the review process.
...

@KhushamBansal
Copy link
Contributor Author

KhushamBansal commented Jan 7, 2026

image

This is after the change.

image This is before the change.

@Rajesh-Nagarajan-11
Copy link
Member

Rajesh-Nagarajan-11 commented Jan 7, 2026

Still you can minimise the size of background image ( 5 logo)

@l5io
Copy link
Contributor

l5io commented Jan 7, 2026

🚀 Preview for commit b33ee6a at: https://695e5874ebd1c649ceb05703--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Jan 7, 2026

🚀 Preview for commit 16bb27e at: https://695e5e11fee4945227794fbf--layer5.netlify.app

@KhushamBansal
Fix:
770453e 
Signed-off-by: Khusham Bansal <[email protected]>
@l5io
Copy link
Contributor

l5io commented Jan 7, 2026

🚀 Preview for commit 770453e at: https://695e630ebdc541729fc19ace--layer5.netlify.app

@KhushamBansal
Fix:
0a594c9 
Signed-off-by: Khusham Bansal <[email protected]>
@l5io
Copy link
Contributor

l5io commented Jan 7, 2026

🚀 Preview for commit 0a594c9 at: https://695e7e34cf425dc03c0a6e97--layer5.netlify.app

@KhushamBansal
Copy link
Contributor Author

KhushamBansal commented Jan 7, 2026 •
edited
Loading

@Rajesh-Nagarajan-11 @kishore08-07
I have verified that the changes fix all the linked components. I have attached the images below. Let me know if any other changes are to be made.

image image image

@kishore08-07
Copy link
Contributor

kishore08-07 commented Jan 9, 2026

@KhushamBansal Have you checked the desktop view as well?

@KhushamBansal
Copy link
Contributor Author

KhushamBansal commented Jan 9, 2026

@kishore08-07
Yes,I have checked the desktop view as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rajesh-Nagarajan-11 Rajesh-Nagarajan-11 Rajesh-Nagarajan-11 requested changes

+1 more reviewer

@kishore08-07 kishore08-07 kishore08-07 left review comments

Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

area/careers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CTA image padding and layout break on mobile view

5 participants

@KhushamBansal @l5io @CodexRaunak @kishore08-07 @Rajesh-Nagarajan-11