Fix: Themed Modal #1086
Closed
Fix: Themed Modal #1086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vr-varad <[email protected]>
|
@vr-varad get people to review. Neither @FaheemOnHub nor @vishalvivekm have responded here for the past 24 hours, so you’re going to have to chase them down. |
Signed-off-by: vr-varad <[email protected]>
Signed-off-by: vr-varad <[email protected]>
Signed-off-by: vr-varad <[email protected]>
FaheemOnHub
approved these changes
Jun 22, 2025
vishalvivekm
approved these changes
Jun 22, 2025
leecalcote
reviewed
Jun 22, 2025
| @@ -68,6 +68,9 @@ interface UserInviteModalProps { | |||
| }; | |||
| isAssignUserRolesAllowed: boolean; | |||
| useLazyGetTeamsQuery: any; | |||
|
|
|||
| /* eslint-disable @typescript-eslint/no-explicit-any */ | |||
There was a problem hiding this comment.
Why is this best practice being ignored?
leecalcote
reviewed
Jun 22, 2025
src/custom/Modal/index.tsx
Outdated
| : darkModalGradient.fotter | ||
| ? theme.palette.mode === 'light' | ||
| ? lightModalGradient.fotter | ||
| : darkModalGradient.fotter |
|
This approach isn't ideal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes keeps all changes for themed Modal to sistent.
Signed commits