feat: added light mode support #1129
Open
+34
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: saurabhraghuvanshii <[email protected]>
hortison
reviewed
Aug 8, 2025
leecalcote
reviewed
Aug 8, 2025
leecalcote
reviewed
Aug 8, 2025
leecalcote
reviewed
Aug 8, 2025
leecalcote
reviewed
Aug 8, 2025
leecalcote
reviewed
Aug 8, 2025
|
|
||
| // Determine colors based on theme when useThemeColors is true | ||
| const tooltipBgColor = useThemeColors | ||
| ? theme.palette.mode === 'dark' |
There was a problem hiding this comment.
This conditional shouldn't be necessary. We can use a single color token / theme reference, which will dynamically reflect the appropriate contrasting color based on selected mode. There should be existing examples which you can use as reference, @saurabhraghuvanshii
There was a problem hiding this comment.
Look in Meshery UI, too, for examples.
There was a problem hiding this comment.
@FaheemOnHub can you offer an example?
Signed-off-by: saurabhraghuvanshii <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
before:
After
This PR fixes # none
Signed commits