feat(utils): add convertToReadableUnit utility function #909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yash37158 <[email protected]>
amitamrutiya
approved these changes
Feb 7, 2025
|
Lint Failing @yash37158 |
Signed-off-by: yash37158 <[email protected]>
|
Hey @amitamrutiya I have fixed the linting issue still check is failing
|
|
It is really weird. why this is failing only on your PR? |
|
try running |
Signed-off-by: yash37158 <[email protected]>
|
@amitamrutiya I have pushed the fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
Added a reusable utility function for resource detail formatting:
convertToReadableUnitfunction that converts bytes to human-readable units (KiB/MiB/GiB)Extension of PR number 13486
Signed commits