Changes to accommodate methods removed in Python 3.8#43
Open
zymurgybc wants to merge 1 commit intolazylibrarian:masterfrom
Open
Changes to accommodate methods removed in Python 3.8#43zymurgybc wants to merge 1 commit intolazylibrarian:masterfrom
zymurgybc wants to merge 1 commit intolazylibrarian:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two older deprecated methods were removed in Python 3.8 and prevent startup. One method is now implemented in the html module.
if _version_info <=(3,7):
from cgi import escape as _escape
else:
from html import escape as _escape
The other simply seems to be removed, so I made the line conditional with older versions.
I also fixed an "is not" expression with a literal which should be a !=