Correctly handle vsnprintf truncation#19
Open
sbohrer wants to merge 1 commit intolazytiger:masterfrom
Open
Conversation
From the vsnprintf man page:
```
The functions snprintf() and vsnprintf() do not write more than
size bytes (including the terminating null byte ('\0')). If the output
was truncated due to this limit, then the return value is the number of
characters (excluding the terminating null byte) which would have been
written to the final string if enough space had been available. Thus,
a re‐ turn value of size or more means that the output was truncated.
(See also below under CAVEATS.)
```
Without this fix performing an ipset list where `n == length` would
result in a rust String that was terminated with a null byte, and this
would fail to parse returning an error.
For example:
```
called `Result::unwrap()` on an `Err` value: InvalidOutput("91.99.252.18\0")
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the vsnprintf man page:
Without this fix performing an ipset list where
n == lengthwould result in a rust String that was terminated with a null byte, and this would fail to parse returning an error.For example: