Add optional forward parameter to SmileSection pricing methods#2489
Open
quantales wants to merge 1 commit intolballabio:masterfrom
Open
Add optional forward parameter to SmileSection pricing methods#2489quantales wants to merge 1 commit intolballabio:masterfrom
quantales wants to merge 1 commit intolballabio:masterfrom
Conversation
30293a3 to
5878112
Compare
c9f0b44 to
fd39138
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes adding an optional
forwardparameter (defaulting toNull<Real>()) toSmileSection::optionPrice(),digitalOptionPrice(),vega(), anddensity().Currently these methods rely on
atmLevel()to obtain the forward, and fail at runtime if it returnsNull<Real>().This works for IR smile sections which always know their forward, but equity/FX smile sections often don't. A
SmileSectionobtained from aBlackVolTermStructure(see #2487) or constructed from market data without a forward hits thisQL_REQUIREas soon asoptionPrice()ordensity()is called.The optional
forwardparameter lets callers provide the forward at the call site when the smile doesn't know it.When
forwardis not passed (or passed asNull<Real>()), behavior is unchanged,atmLevel()is used as before. Fully backwards compatible.All derived classes that override these methods (
NoArbSabrSmileSection,ZabrSmileSection,Gaussian1dSmileSection,KahaleSmileSection,AtmAdjustedSmileSection) have been updated to match the new signatures. They ignore theforwardparameter since they already know their forward viaatmLevel().Note: for
digitalOptionPriceanddensity, theforwardparameter comes aftergapto preserve backwards compatibility.Tests: forward-aware calls on a forward-unaware
FlatSmileSectionproduce correct prices (verified againstblackFormula), and are consistent withatmLevel-based results on forward-aware smiles. Full suite passes.@pcaspers, @lballabio, would appreciate your feedback on this, especially regarding the parameter ordering for
digitalOptionPriceanddensitywhereforwardcomes aftergap.