Unify duplicate Dockerfiles using build arguments#102
Merged
Haydnspass merged 5 commits intomainfrom Jan 24, 2026
Merged
Conversation
Co-authored-by: Haydnspass <16120273+Haydnspass@users.noreply.github.com>
Co-authored-by: Haydnspass <16120273+Haydnspass@users.noreply.github.com>
Co-authored-by: Haydnspass <16120273+Haydnspass@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Harmonize duplicate .Dockerfiles into one
Unify duplicate Dockerfiles using build arguments
Jan 24, 2026
Haydnspass
requested changes
Jan 24, 2026
Collaborator
There was a problem hiding this comment.
use a matrix and test both scenarios for which we had dedicated dockerfiles before
Contributor
Author
There was a problem hiding this comment.
Added matrix strategy to test both Ubuntu 22.04 (CUDA 12.4.1, ROS humble) and Ubuntu 24.04 (CUDA 13.1.0, ROS jazzy) configurations in commit 7501f75.
Co-authored-by: Haydnspass <16120273+Haydnspass@users.noreply.github.com>
Haydnspass
approved these changes
Jan 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminates duplication between
cuda-12.4.1-ubuntu-22.04.Dockerfileandcuda-13.1.0-ubuntu-24.04.Dockerfileby consolidating into a single parameterized Dockerfile.Changes
New unified Dockerfile (
.docker/Dockerfile) with build arguments:UBUNTU_VERSION: 22.04 | 24.04 (default: 24.04)CUDA_VERSION: 12.4.1 | 13.1.0 (default: 13.1.0)ROS_DISTRO: humble | jazzy (default: jazzy)Conditional logic for Ubuntu version differences:
python3-setuptoolspackage (22.04 only)Updated references:
Removed duplicate Dockerfiles
Usage
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.