[WIP] Basic tests with circle

.gitignore

@@ -0,0 +1,3 @@
+composer.lock
+/drush/
+/vendor/

circle.yml

@@ -0,0 +1,70 @@
+# https://circleci.com/docs/configuration#machine
+machine:
+  php:
+    # https://circleci.com/docs/environment#php
+    version: 5.6.14
+  environment:
+    # DB config. Using default CircleCI's database.
+    DB_NAME: "circle_test"
+    DB_USERNAME: "ubuntu"
+    DB_PASSWORD: ""
+    DOCROOT: "$HOME/drupalcore"
+    SERVER: server.local
+    WEB_USER: $(whoami)
+    WEB_GROUP: www-data
+  hosts:
+    server.local: 127.0.0.1
+
+dependencies:
+  cache_directories:
+    - ~/.composer/cache
+  pre:
+    - composer global require "hirak/prestissimo:^0.3"
+    - composer global require drush/drush:8.*
+    # @todo, composer is probably a bad/slow way to install core here.
+    # Use something like drush's 
+    - git clone --branch 8.1.x https://git.drupal.org/project/drupal.git $DOCROOT
+    - cd $DOCROOT && composer install
+    # Add apache config.
+    # Modify user to make sure that there will be no permission issues.
+    - sudo usermod -a -G $WEB_GROUP $WEB_USER
+    # Add apache config.
+    - |
+      echo "<VirtualHost *:80>
+          UseCanonicalName Off
+          DocumentRoot %DOCROOT%
+          ServerName %SERVER%
+        <Directory %DOCROOT%>
+          Options FollowSymLinks
+          AllowOverride All
+          RewriteEngine On
+          RewriteBase /
+          RewriteCond %{REQUEST_FILENAME} !-f
+          RewriteCond %{REQUEST_FILENAME} !-d
+          RewriteRule %DOCROOT%/(.*)$ index.php/?q=$1 [L,QSA]
+          Order allow,deny
+          Allow from all
+        </Directory>
+      </VirtualHost>" > apache-vhost.conf
+    - cp apache-vhost.conf /etc/apache2/sites-available/default
+    - sudo sed -e "s?%DOCROOT%?$DOCROOT?g" --in-place /etc/apache2/sites-available/default
+    - sudo sed -e "s?%SERVER%?$SERVER?g" --in-place /etc/apache2/sites-available/default
+    - sudo a2enmod rewrite
+    - sudo service apache2 restart
+test:
+  pre:
+    # Copy the settings.local into place
+    # Disable sendmail binary to suppress any mailouts.
+    - echo 'sendmail_path = /bin/true' >> ~/.phpenv/versions/$(phpenv version-name)/etc/conf.d/circle.ini
+    - drush --yes --root=$DOCROOT site-install --db-url=mysql://$DB_USERNAME:[email protected]/$DB_NAME
+    - curl $SERVER
+    - cd $DOCROOT && drush en simpletest  -y
+    - cd $DOCROOT && composer config repositories.d8lcache vcs [email protected]:lcache/drupal-8.git
+    - cd $DOCROOT && composer require "drupal/lcache:dev-master#$CIRCLE_SHA1"
+    - cd $DOCROOT && drush en lcache -y
+
+  override:
+    - ./vendor/bin/phpcs --report=full --extensions=php,module,inc,theme,info --standard=vendor/drupal/coder/coder_sniffer/Drupal/ --ignore=vendor .
+    - cd $DOCROOT && /home/ubuntu/.phpenv/shims/php  core/scripts/run-tests.sh  --url  $SERVER  --module lcache    --php  /home/ubuntu/.phpenv/shims/php --verbose  --color
+
+

composer.json

@@ -13,7 +13,7 @@
         "lcache/lcache": "v0.3.*"
     },
     "require-dev": {
-        "phpunit/phpunit": "4.*",
-        "phpunit/dbunit": "*"
+        "drupal/coder": "^8.2.0-beta1",
+        "squizlabs/php_codesniffer": "2.0.*@dev"
     }
 }

lcache.services.yml

@@ -4,7 +4,7 @@ services:
     arguments: ['@database']
   lcache.integrated:
     class: LCache\Integrated
-    factory: cache.backend.lcache:getIntegratedLCache
+    factory: cache.backend.lcache:getIntegratedLcache
   cache_tags.invalidator.lcache:
     class: Drupal\lcache\BackendInvalidator
     arguments: ['@lcache.integrated']

src/Backend.php

@@ -30,6 +30,7 @@ class Backend implements CacheBackendInterface {
 
   /**
    * Constructs a Backend object.
+   *
    * @param string $bin
    *   The bin name.
    */
@@ -38,6 +39,12 @@ public function __construct($bin, \LCache\Integrated $integrated) {
     $this->integrated = $integrated;
   }
 
+  /**
+   * Return an Address for a given cid.
+   *
+   * @param string $cid
+   *   The Cache ID.
+   */
   protected function getAddress($cid) {
     return new \LCache\Address($this->bin, $cid);
   }
@@ -55,8 +62,17 @@ public function get($cid, $allow_invalid = FALSE) {
 
     $response = new \stdClass();
     $response->cid = $cid;
+    $response->valid = TRUE;
     $response->data = $entry->value;
     $response->created = $entry->created;
+
+    // LCache the library uses NULL for permanent
+    // but that may confuse parts of Drupal.
+    // @todo, investigate if there is a better answer than this munging.
+    if (is_null($entry->expiration)) {
+      $entry->expiration = CacheBackendInterface::CACHE_PERMANENT;
+    }
+
     $response->expire = $entry->expiration;
     return $response;
   }
@@ -65,14 +81,17 @@ public function get($cid, $allow_invalid = FALSE) {
    * {@inheritdoc}
    */
   public function getMultiple(&$cids, $allow_invalid = FALSE) {
-    if (empty($cids)) return;
+    if (empty($cids)) {
+      return;
+    }
     $cache = array();
     foreach ($cids as $cid) {
       $c = $this->get($cid);
       if (!empty($c)) {
         $cache[$cid] = $c;
       }
     }
+    $cids = array_diff($cids, array_keys($cache));
     return $cache;
   }
 
@@ -164,15 +183,6 @@ public function invalidateAll() {
     $this->delete(NULL);
   }
 
-  /**
-   * {@inheritdoc}
-   */
-  public function invalidateTags(array $tags) {
-    foreach ($tags as $tag) {
-      $this->integrated->deleteTag($tag);
-    }
-  }
-
   /**
    * {@inheritdoc}
    */
@@ -188,7 +198,7 @@ public function garbageCollection() {
   }
 
   /**
-   * (@inheritdoc)
+   * {@inheritdoc}
    */
   public function isEmpty() {
     return FALSE;

src/BackendFactory.php

@@ -9,13 +9,19 @@
 
 use Drupal\Core\Database\Connection;
 
+/**
+ * A Factory for an LCache backend.
+ */
 class BackendFactory {
 
   protected $integrated;
 
-  protected function get_pdo_handle() {
+  /**
+   * Constructs the the databse connection for L2.
+   */
+  protected function getPdoHandle() {
     $db_info = $this->connection->getConnectionOptions();
-    $dsn = 'mysql:host='. $db_info['host']. ';port='. $db_info['port'] .';dbname='. $db_info['database'];
+    $dsn = 'mysql:host=' . $db_info['host'] . ';port=' . $db_info['port'] . ';dbname=' . $db_info['database'];
     $options = array(\PDO::ATTR_TIMEOUT => 2, \PDO::MYSQL_ATTR_INIT_COMMAND => 'SET sql_mode="ANSI_QUOTES,STRICT_ALL_TABLES"');
     $dbh = new \PDO($dsn, $db_info['username'], $db_info['password'], $options);
     $dbh->setAttribute(\PDO::ATTR_ERRMODE, \PDO::ERRMODE_EXCEPTION);
@@ -34,15 +40,15 @@ public function __construct(Connection $connection) {
     if (php_sapi_name() !== 'cli') {
       $l1 = new \LCache\APCuL1();
     }
-    $l2 = new \LCache\DatabaseL2($this->get_pdo_handle());
+    $l2 = new \LCache\DatabaseL2($this->getPdoHandle());
     $this->integrated = new \LCache\Integrated($l1, $l2);
     $this->integrated->synchronize();
   }
 
   /**
    * Gets an LCache Backend for the specified cache bin.
    *
-   * @param $bin
+   * @param string $bin
    *   The cache bin for which the object is created.
    *
    * @return \Drupal\lcache\Backend
@@ -58,8 +64,7 @@ public function get($bin) {
    * @return \LCache\Integrated
    *   The integrated cache backend.
    */
-  public function getIntegratedLCache() {
+  public function getIntegratedLcache() {
     return $this->integrated;
   }
-
 }

src/BackendInvalidator.php

@@ -9,10 +9,19 @@
 
 use Drupal\Core\Cache\CacheTagsInvalidatorInterface;
 
+/**
+ * Invalidates LCache tags.
+ */
 class BackendInvalidator implements CacheTagsInvalidatorInterface {
 
   protected $integrated;
 
+  /**
+   * Constructs an invalidator object.
+   *
+   * @param \LCache\Integrated $integrated
+   *   The integrated Cache object were invalidations will be run.
+   */
   public function __construct(\LCache\Integrated $integrated) {
     $this->integrated = $integrated;
   }
@@ -22,8 +31,7 @@ public function __construct(\LCache\Integrated $integrated) {
    */
   public function invalidateTags(array $tags) {
     foreach ($tags as $tag) {
-        $this->integrated->deleteTag($tag);
+      $this->integrated->deleteTag($tag);
     }
   }
-
 }