Merged
Conversation
- Convert all property docblocks to typed properties - Add return types to all methods (e.g., get(): ?object) - Add parameter types (e.g., prettifyJson(string|false $content)) - Upgrade PHPStan level from 5 to 8 - Update ECS configuration from PHP 7.1 to PHP 8.2 standards - Add proper generic type annotations for Doctrine Collections - Modernize test files to comply with PHPStan level 8 BREAKING: Requires PHP 8.2+ due to union types and typed properties
The ignore patterns were not matching any errors, causing PHPStan to fail with "unmatched ignored error" errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING: Requires PHP 8.2+ due to union types and typed properties