Open
Conversation
fredericpoitevin
approved these changes
Mar 20, 2026
fredericpoitevin
left a comment
There was a problem hiding this comment.
I went through this PR quickly since we don't intend to use the serial approach going forward. To make this clear, please address the single comment I made in the README.
It would have been nice to try and refactor this with the parallel approach given how much redundancy there is. I am a bit worried about the technical debt that we are creating here...
That being said, I understand we don't want to lose these scripts so let's merge after we made it clear that the serial approach is obsolete in the README.
| @@ -0,0 +1,483 @@ | |||
| # Coyote Protector Serial Workflow | |||
|
|
|||
There was a problem hiding this comment.
Add in bold mention that the serial approach is not recommended and only kept for legacy purposes.
Added a note indicating that this version is obsolete and kept for legacy purposes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old sequential pipeline. Some overlaps with the parallel one, refactoring might be useful in the future.