Skip to content

Branch sequential xtc pipeline#7

Open
PierreLouis-Monteil wants to merge 9 commits intomainfrom
branch_sequential_xtc_pipeline
Open

Branch sequential xtc pipeline#7
PierreLouis-Monteil wants to merge 9 commits intomainfrom
branch_sequential_xtc_pipeline

Conversation

@PierreLouis-Monteil
Copy link
Copy Markdown

Old sequential pipeline. Some overlaps with the parallel one, refactoring might be useful in the future.

Copy link
Copy Markdown

@fredericpoitevin fredericpoitevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through this PR quickly since we don't intend to use the serial approach going forward. To make this clear, please address the single comment I made in the README.

It would have been nice to try and refactor this with the parallel approach given how much redundancy there is. I am a bit worried about the technical debt that we are creating here...

That being said, I understand we don't want to lose these scripts so let's merge after we made it clear that the serial approach is obsolete in the README.

@@ -0,0 +1,483 @@
# Coyote Protector Serial Workflow

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add in bold mention that the serial approach is not recommended and only kept for legacy purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants