[pull] main from amidaware:main #2
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| rem List apps installed by Chocolatey | ||
|
|
||
| set "chocoExePath=%PROGRAMDATA%\chocolatey\choco.exe" | ||
|
|
||
| "%chocoExePath%" list |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,71 +1,127 @@ | ||
| <# | ||
| .SYNOPSIS | ||
| Installs, uninstalls, upgrades, or lists software with rate limiting when run with Hosts parameter | ||
| .DESCRIPTION | ||
| This script uses Chocolatey to manage software packages. It introduces rate limiting when run on multiple hosts to avoid hitting rate limits at chocolatey.org. Use the Hosts parameter to specify the number of computers the script is running on. | ||
| .PARAMETER Mode | ||
| 5 modes: 'install' (default), 'uninstall', 'upgrade', 'upgrade-only-installed' or 'list'. | ||
| Mode 'install' installs the software specified by "PackageName" | ||
| Mode 'uninstall' removes the software specified by "PackageName" | ||
| Mode 'upgrade' checks for newer version and upgrades the package(s). If package is not existing on system it gets installed (default behaviour of chocolatey). If no PackageName is given all installed packages are being updated. | ||
| Mode 'upgrade-only-installed' checks for newer version of the package(s) and upgrades it. It will _not_ install new software (by adding --failonnotinstalled to the choco-command). | ||
| Mode 'list' lists packages which are installed by chocolatey on the target | ||
| Mode 'list-upgradeable' lists packages which are installed by chocolatey on the target but have updates available | ||
| .PARAMETER Hosts | ||
| Use this to specify the number of computer(s) you're running the command on. This will dynamically introduce waits to try and minimize the chance of hitting rate limits (20/min) on the chocolatey.org site: Hosts 20 | ||
| .PARAMETER PackageName | ||
| Use this to specify which software('s) to install eg: PackageName googlechrome. You can use multiple values using comma separated. | ||
| .EXAMPLE | ||
| -Hosts 20 -PackageName googlechrome | ||
| .EXAMPLE | ||
| -Mode upgrade -Hosts 50 -PackageName chocolatey | ||
| .EXAMPLE | ||
| -Mode upgrade-only-installed -Hosts 20 -PackageName googlechrome,firefox | ||
| .EXAMPLE | ||
| -Mode list | ||
| .NOTES | ||
| 9/2021 v1 Initial release by @silversword411 and @bradhawkins | ||
| 11/14/2021 v1.1 Fixing typos and logic flow | ||
| 12/8/2023 v1.3 Adding list, making choco full path | ||
| 2/22/2024 v1.4 Adding 'upgrade-only-installed' as mode by @derfladi | ||
| 3/5/2024 v1.5 silversword411 Adding --no-progress to minimize output | ||
| 5/21/2024 v1.6 silversword411 Adding list-upgradeable | ||
| #> | ||
|
|
||
| param ( | ||
| [Parameter(Mandatory = $false)] | ||
| [int] $Hosts = 0, | ||
|
|
||
| [Parameter(Mandatory = $false)] | ||
| [string[]] $PackageName, | ||
|
|
||
| [Parameter(Mandatory = $false)] | ||
| [ValidateSet("install", "uninstall", "upgrade", "upgrade-only-installed", "list", "list-upgradeable")] | ||
| [string] $Mode = "install" | ||
| ) | ||
|
|
||
| $chocoExePath = "$env:PROGRAMDATA\chocolatey\choco.exe" | ||
|
|
||
| if (-not (Test-Path $chocoExePath)) { | ||
| Write-Host "Chocolatey is not installed." | ||
| Exit 1 | ||
| } | ||
|
|
||
| $ErrorCount = 0 | ||
|
|
||
| if ($Mode -ne "upgrade" -and $Mode -ne "upgrade-only-installed" -and $Mode -ne "list" -and $Mode -ne "list-upgradeable" -and -not $PackageName) { | ||
| Write-Host "Error: No package name provided. Please specify a package name, e.g., `-PackageName googlechrome`." | ||
| Exit 1 | ||
| } | ||
|
|
||
| # Calculate random delay based on the number of hosts | ||
| $randDelay = if ($Hosts -gt 0) { Get-Random -Minimum 1 -Maximum (($Hosts + 1) * 6) } else { 1 } | ||
|
|
||
| Write-Host "Sleeping $randDelay seconds" | ||
| Start-Sleep -Seconds $randDelay | ||
|
|
||
| switch ($Mode) { | ||
| "install" { | ||
| if ($PackageName) { | ||
| foreach ($package in $PackageName) { | ||
| & $chocoExePath install $package -y --no-progress | ||
| if ($LASTEXITCODE -ne 0) { $ErrorCount++ } | ||
| } | ||
| } | ||
| } | ||
| "uninstall" { | ||
| if ($PackageName) { | ||
| foreach ($package in $PackageName) { | ||
| & $chocoExePath uninstall $package -y | ||
| if ($LASTEXITCODE -ne 0) { $ErrorCount++ } | ||
| } | ||
| } | ||
| } | ||
| "upgrade" { | ||
| if ($PackageName) { | ||
| foreach ($package in $PackageName) { | ||
| & $chocoExePath upgrade $package -y --no-progress | ||
| if ($LASTEXITCODE -ne 0) { $ErrorCount++ } | ||
| } | ||
| } | ||
| else { | ||
| & $chocoExePath upgrade all -y --no-progress | ||
| } | ||
| } | ||
| "upgrade-only-installed" { | ||
| if ($PackageName) { | ||
| foreach ($package in $PackageName) { | ||
| & $chocoExePath upgrade $package --failonnotinstalled -y | ||
| if ($LASTEXITCODE -ne 0) { $ErrorCount++ } | ||
| } | ||
| } | ||
| else { | ||
| & $chocoExePath upgrade all --failonnotinstalled -y | ||
| } | ||
| } | ||
| "list" { | ||
| & $chocoExePath list | ||
| } | ||
| "list-upgradeable" { | ||
| & $chocoExePath outdated | ||
| } | ||
| } | ||
|
|
||
| if ($ErrorCount -gt 0) { | ||
| Write-Host "$ErrorCount errors occurred during the operation." | ||
|
There was a problem hiding this comment. Bug: Script exits successfully even when errors occurThe script always exits with code 0 via |
||
| } | ||
|
|
||
| Exit 0 | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Missing exit in non-customField success path
When antivirus is found and
$customFieldis not specified, the script outputs the antivirus information but never explicitly exits. The script then falls through without an exit code, potentially causing issues with how the calling system interprets the result. The$customFieldpath correctly usesexit 0, but the else branch is missing an exit statement.