Conversation
- Add extractSwiftTestingName() helper function that handles both: - Quoted format: Test "Human readable name" ... - Unquoted format: Test functionName() ... - Replace 4 separate parsing blocks (~80 lines) with 1 universal block that uses the helper function - Add tests for quoted format and mixed format scenarios - Remove code duplication while maintaining full backward compatibility Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Hey @jeremyabannister , thanks for the contribution! Your PR correctly identified the gap in Swift Testing support — the SF Symbols and unquoted function names were indeed missing from the parser. I've pushed a small refactoring commit on top of your work. The 4 separate parsing blocks (quoted/unquoted × recorded/failed) are now merged into one using an Also added a couple of tests for the quoted All 278 tests pass. |
|
Mind giving it a quick test on your end? Want to make sure the refactored parsing still catches everything you were seeing before we merge. |
|
Yep, still working for me, thanks for cleaning it up |
2 participants
I had Codex make these changes. I haven't taken the time to learn about the implementation of xcsift so as to be able to review the changes, but I thought that if I provide a test and an implementation that at least works (even if it's not elegant) it might be helpful in getting Swift Testing support added to xcsift.