Skip to content

remove old comments, generalize check #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Raycoms merged 1 commit into from
Mar 22, 2026
+2 −5
Merged

remove old comments, generalize check #824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/com/ldtteam/structurize/placement/StructurePlacer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import net.minecraft.world.level.block.*;
import net.minecraft.world.level.block.entity.BlockEntity;
import net.minecraft.world.level.block.state.BlockState;
import net.minecraft.world.level.block.state.properties.BlockStateProperties;
import net.minecraft.world.level.block.state.properties.DoubleBlockHalf;
import net.minecraft.world.level.material.FluidState;
import net.minecraft.world.phys.AABB;
Expand Down Expand Up @@ -358,7 +359,7 @@ else if (requiredItems == null)
{
if (!sameBlockInWorld
&& !worldState.isAir()
&& !(worldState.getBlock() instanceof DoublePlantBlock && worldState.getValue(DoublePlantBlock.HALF).equals(DoubleBlockHalf.UPPER)))
&& (!localState.hasProperty(BlockStateProperties.DOUBLE_BLOCK_HALF) || localState.getValue(DoublePlantBlock.HALF).equals(DoubleBlockHalf.LOWER)))
{
removalHandler.handleRemoval(handler, world, worldPos, tileEntityData);
}
Expand Down
4 changes: 0 additions & 4 deletions src/main/java/com/ldtteam/structurize/placement/handlers/placement/IPlacementHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,6 @@ static boolean doesWorldStateMatchBlueprintState(@NotNull BlockInfo blockInfo, @
blockEntityData = new Tuple<>(blockEntity, blockInfo.getTileEntityData());
}

//todo domum blocks on minecol side
//todo minecolonies racks on minecol side
//todo minecolonies allow conversion of dirt like to dirt

return placementHandler.doesWorldStateMatchBlueprintState(structureHandler.getWorld().getBlockState(worldPos), blockInfo.getState(), blockEntityData, structureHandler);
}

Expand Down
Loading