chore: sonarcloud / smells

Author: lduchosal

src/TestProject/CidrClassLessUnitTest.cs

@@ -94,20 +94,6 @@ public void TestTryGuessCidrE()
         Assert.AreEqual(32, cidr, "cidr");
     }
 
-    /// <summary>
-    /// Test.
-    /// </summary>
-    [TestMethod]
-    public void TestIpV6TryGuessCidrNull()
-    {
-        var cidrguess = new CidrClassLess();
-
-        bool parsed = cidrguess.TryGuessCidr(null, out byte cidr);
-
-        Assert.IsFalse(parsed, "parsed");
-        Assert.AreEqual(0, cidr, "cidr");
-    }
-
     /// <summary>
     /// Test.
     /// </summary>

src/TestProject/EqualsUnitTest.cs

@@ -20,7 +20,7 @@ public void TestEquals_ipv6_ipv4_0()
         var network2 = IPNetwork2.Parse("0.0.0.0/32");
         bool result = network1.Equals(network2);
 
-        Assert.IsFalse(result, "equals");
+        Assert.IsFalse(result);
     }
 
     /// <summary>
@@ -29,11 +29,11 @@ public void TestEquals_ipv6_ipv4_0()
     [TestMethod]
     public void TestEquals_ipv4_1()
     {
-        var network1 = IPNetwork2.Parse("192.168.0.1/24");
-        var network2 = IPNetwork2.Parse("192.168.0.1/24");
+        var network1 = IPNetwork2.Parse("192.168.10.1/24");
+        var network2 = IPNetwork2.Parse("192.168.10.1/24");
         bool result = network1.Equals(network2);
 
-        Assert.IsTrue(result, "equals");
+        Assert.IsTrue(result);
     }
 
     /// <summary>
@@ -42,11 +42,10 @@ public void TestEquals_ipv4_1()
     [TestMethod]
     public void TestEquals_ipv4_2()
     {
-        var network1 = IPNetwork2.Parse("192.168.0.1/24");
-        IPNetwork2 network2 = null;
-        bool result = network1.Equals(network2);
+        var network1 = IPNetwork2.Parse("192.168.20.1/24");
+        bool result = network1.Equals(null);
 
-        Assert.IsFalse(result, "equals");
+        Assert.IsFalse(result);
     }
 
     /// <summary>
@@ -59,7 +58,7 @@ public void TestEquals_ipv4_3()
         object network2 = string.Empty;
         bool result = network1.Equals(network2);
 
-        Assert.IsFalse(result, "equals");
+        Assert.IsFalse(result);
     }
 
     /// <summary>
@@ -72,7 +71,7 @@ public void TestEquals_ipv4_4()
         var network2 = IPNetwork2.Parse("192.168.0.1/25");
         bool result = network1.Equals(network2);
 
-        Assert.IsFalse(result, "equals");
+        Assert.IsFalse(result);
     }
 
     /// <summary>
@@ -85,7 +84,7 @@ public void TestEquals_ipv4_5()
         var network2 = IPNetwork2.Parse("192.168.1.1/24");
         bool result = network1.Equals(network2);
 
-        Assert.IsFalse(result, "equals");
+        Assert.IsFalse(result);
     }
 
     /// <summary>
@@ -94,11 +93,11 @@ public void TestEquals_ipv4_5()
     [TestMethod]
     public void TestEquals_ipv6_1()
     {
-        var network1 = IPNetwork2.Parse("::1/128");
-        var network2 = IPNetwork2.Parse("::1/128");
+        var network1 = IPNetwork2.Parse("::11/128");
+        var network2 = IPNetwork2.Parse("::11/128");
         bool result = network1.Equals(network2);
 
-        Assert.IsTrue(result, "equals");
+        Assert.IsTrue(result);
     }
 
     /// <summary>
@@ -107,11 +106,10 @@ public void TestEquals_ipv6_1()
     [TestMethod]
     public void TestEquals_ipv6_2()
     {
-        var network1 = IPNetwork2.Parse("::1/128");
-        IPNetwork2 network2 = null;
-        bool result = network1.Equals(network2);
+        var network1 = IPNetwork2.Parse("::12/128");
+        bool result = network1.Equals(null);
 
-        Assert.IsFalse(result, "equals");
+        Assert.IsFalse(result);
     }
 
     /// <summary>
@@ -120,11 +118,11 @@ public void TestEquals_ipv6_2()
     [TestMethod]
     public void TestEquals_ipv6_3()
     {
-        var network1 = IPNetwork2.Parse("::1/128");
+        var network1 = IPNetwork2.Parse("::13/128");
         object network2 = string.Empty;
         bool result = network1.Equals(network2);
 
-        Assert.IsFalse(result, "equals");
+        Assert.IsFalse(result);
     }
 
     /// <summary>
@@ -133,11 +131,11 @@ public void TestEquals_ipv6_3()
     [TestMethod]
     public void TestEquals_ipv6_4()
     {
-        var network1 = IPNetwork2.Parse("::1/128");
-        var network2 = IPNetwork2.Parse("::1/127");
+        var network1 = IPNetwork2.Parse("::14/128");
+        var network2 = IPNetwork2.Parse("::14/127");
         bool result = network1.Equals(network2);
 
-        Assert.IsFalse(result, "equals");
+        Assert.IsFalse(result);
     }
 
     /// <summary>
@@ -150,6 +148,6 @@ public void TestEquals_ipv6_5()
         var network2 = IPNetwork2.Parse("::10/128");
         bool result = network1.Equals(network2);
 
-        Assert.IsFalse(result, "equals");
+        Assert.IsFalse(result);
     }
 }

src/TestProject/GetHashCodeUnitTest.cs

@@ -59,8 +59,6 @@ public void TestGetHashCode_Dictionary_failed()
         var ipnetwork = IPNetwork2.Parse("1.0.0.0/1");
         var ipnetwork2 = IPNetwork2.Parse("1.0.0.0/1");
         var dic = new Dictionary<IPNetwork2, int>();
-        bool contains1 = dic.ContainsKey(ipnetwork);
-        bool contains2 = dic.ContainsKey(ipnetwork2);
 
         dic.Add(ipnetwork, 0);
         bool contains3 = dic.ContainsKey(ipnetwork);
@@ -70,8 +68,6 @@ public void TestGetHashCode_Dictionary_failed()
         bool contains5 = dic.ContainsKey(ipnetwork);
         bool contains6 = dic.ContainsKey(ipnetwork2);
 
-        Assert.IsFalse(contains1, "contains1");
-        Assert.IsFalse(contains2, "contains2");
         Assert.IsTrue(contains3, "contains3");
         Assert.IsTrue(contains4, "contains4");
         Assert.IsTrue(contains5, "contains5");