feat/code-quality

src/ConsoleApplication/ActionEnum.cs

@@ -5,7 +5,7 @@
 namespace System.Net;
 
 /// <summary>
-/// Switch and actions
+/// Switch and actions.
 /// </summary>
 public enum ActionEnum
 {

src/System.Net.IPNetwork/BigIntegerExtensions.cs

@@ -149,8 +149,7 @@ public static string ToOctalString(this BigInteger bigint)
     ///
     /// </summary>
     /// <param name="input">The positive number to bitwise reverse.</param>
-    /// <param name="width">The width of the parameter.
-    /// </param>
+    /// <param name="width">The width of the parameter.</param>
     /// <returns>A number representing the input bitwise reversed.</returns>
     public static BigInteger PositiveReverse(this BigInteger input, int width)
     {

src/System.Net.IPNetwork/CidrClassLess.cs

@@ -22,21 +22,20 @@ public sealed class CidrClassLess : ICidrGuess
     /// <returns>true if ip was converted successfully; otherwise, false.</returns>
     public bool TryGuessCidr(string ip, out byte cidr)
     {
-            IPAddress ipaddress = null;
-            bool parsed = IPAddress.TryParse(string.Format("{0}", ip), out ipaddress);
-            if (parsed == false)
-            {
-                cidr = 0;
-                return false;
-            }
-
-            if (ipaddress.AddressFamily == AddressFamily.InterNetworkV6)
-            {
-                cidr = 128;
-                return true;
-            }
+        bool parsed = IPAddress.TryParse(string.Format("{0}", ip), out IPAddress ipaddress);
+        if (parsed == false)
+        {
+            cidr = 0;
+            return false;
+        }
 
-            cidr = 32;
+        if (ipaddress.AddressFamily == AddressFamily.InterNetworkV6)
+        {
+            cidr = 128;
             return true;
         }
+
+        cidr = 32;
+        return true;
+    }
 }

src/System.Net.IPNetwork/IPNetwork2ToCidr.cs

@@ -56,7 +56,7 @@ private static void InternalToCidr(bool tryParse, IPAddress netmask, out byte? c
             return;
         }
 
-        bool parsed = IPNetwork2.TryToBigInteger(netmask, out BigInteger? uintNetmask2);
+        IPNetwork2.TryToBigInteger(netmask, out BigInteger? uintNetmask2);
 
         // 20180217 lduchosal
         // impossible to reach code.

src/System.Net.IPNetwork/IPNetwork2TryGuessCidr.cs

@@ -31,14 +31,13 @@ public static bool TryGuessCidr(string ip, out byte cidr)
     /// <returns>true if cidr was converted successfully; otherwise, false.</returns>
     public static bool TryParseCidr(string sidr, AddressFamily family, out byte? cidr)
     {
-        byte b = 0;
-        if (!byte.TryParse(sidr, out b))
+        if (!byte.TryParse(sidr, out byte b))
         {
             cidr = null;
             return false;
         }
 
-        if (!IPNetwork2.TryToNetmask(b, family, out IPAddress netmask))
+        if (!IPNetwork2.TryToNetmask(b, family, out IPAddress _))
         {
             cidr = null;
             return false;

src/System.Net.IPNetwork/IPNetwork2WideSubnet.cs

@@ -49,6 +49,7 @@
         }
 
         var ipnetwork = new IPNetwork2(0, startIP.AddressFamily, 0);
+        // ReSharper disable once ConditionIsAlwaysTrueOrFalse
         for (byte cidr = 32; cidr >= 0; cidr--)
         {
             var wideSubnet = IPNetwork2.Parse(start, cidr);
@@ -151,6 +152,7 @@
         }
 
         var ipn = new IPNetwork2(0, family, 0);
+        // ReSharper disable once ConditionIsAlwaysTrueOrFalse
         for (byte cidr = nnin0.cidr; cidr >= 0; cidr--)
         {
             var wideSubnet = new IPNetwork2(uintNnin0, family, cidr);

src/TestProject/CidrClassFullIpv4UnitTest.cs

@@ -18,10 +18,9 @@ public void TestTryGuessCidrNull()
     {
             var cidrguess = new CidrClassFull();
 
-            byte cidr;
-            bool parsed = cidrguess.TryGuessCidr(null, out cidr);
+            bool parsed = cidrguess.TryGuessCidr(null, out byte cidr);
 
-            Assert.AreEqual(false, parsed, "parsed");
+            Assert.IsFalse(parsed, "parsed");
             Assert.AreEqual(0, cidr, "cidr");
         }
 
@@ -33,10 +32,9 @@ public void TestTryGuessCidrA()
     {
             var cidrguess = new CidrClassFull();
 
-            byte cidr;
-            bool parsed = cidrguess.TryGuessCidr("10.0.0.0", out cidr);
+            bool parsed = cidrguess.TryGuessCidr("10.0.0.0", out byte cidr);
 
-            Assert.AreEqual(true, parsed, "parsed");
+            Assert.IsTrue(parsed, "parsed");
             Assert.AreEqual(8, cidr, "cidr");
         }
 
@@ -48,10 +46,9 @@ public void TestTryGuessCidrB()
     {
             var cidrguess = new CidrClassFull();
 
-            byte cidr;
-            bool parsed = cidrguess.TryGuessCidr("172.0.0.0", out cidr);
+            bool parsed = cidrguess.TryGuessCidr("172.0.0.0", out byte cidr);
 
-            Assert.AreEqual(true, parsed, "parsed");
+            Assert.IsTrue(parsed, "parsed");
             Assert.AreEqual(16, cidr, "cidr");
         }
 
@@ -63,10 +60,9 @@ public void TestTryGuessCidrC()
     {
             var cidrguess = new CidrClassFull();
 
-            byte cidr;
-            bool parsed = cidrguess.TryGuessCidr("192.0.0.0", out cidr);
+            bool parsed = cidrguess.TryGuessCidr("192.0.0.0", out byte cidr);
 
-            Assert.AreEqual(true, parsed, "parsed");
+            Assert.IsTrue(parsed, "parsed");
             Assert.AreEqual(24, cidr, "cidr");
         }
 
@@ -78,10 +74,9 @@ public void TestTryGuessCidrD()
     {
             var cidrguess = new CidrClassFull();
 
-            byte cidr;
-            bool parsed = cidrguess.TryGuessCidr("224.0.0.0", out cidr);
+            bool parsed = cidrguess.TryGuessCidr("224.0.0.0", out byte cidr);
 
-            Assert.AreEqual(true, parsed, "parsed");
+            Assert.IsTrue(parsed, "parsed");
             Assert.AreEqual(24, cidr, "cidr");
         }
 
@@ -93,10 +88,9 @@ public void TestTryGuessCidrE()
     {
             var cidrguess = new CidrClassFull();
 
-            byte cidr;
-            bool parsed = cidrguess.TryGuessCidr("240.0.0.0", out cidr);
+            bool parsed = cidrguess.TryGuessCidr("240.0.0.0", out byte cidr);
 
-            Assert.AreEqual(true, parsed, "parsed");
+            Assert.IsTrue(parsed, "parsed");
             Assert.AreEqual(24, cidr, "cidr");
         }
 }

src/TestProject/CidrClassFullIpv6UnitTest.cs

@@ -18,10 +18,9 @@ public void TestIpV6TryGuessCidrNull()
     {
             var cidrguess = new CidrClassFull();
 
-            byte cidr;
-            bool parsed = cidrguess.TryGuessCidr(null, out cidr);
+            bool parsed = cidrguess.TryGuessCidr(null, out byte cidr);
 
-            Assert.AreEqual(false, parsed, "parsed");
+            Assert.IsFalse(parsed, "parsed");
             Assert.AreEqual(0, cidr, "cidr");
         }
 
@@ -33,10 +32,9 @@ public void TestIpV6TryGuessCidr1()
     {
             var cidrguess = new CidrClassFull();
 
-            byte cidr;
-            bool parsed = cidrguess.TryGuessCidr("::", out cidr);
+            bool parsed = cidrguess.TryGuessCidr("::", out byte cidr);
 
-            Assert.AreEqual(true, parsed, "parsed");
+            Assert.IsTrue(parsed, "parsed");
             Assert.AreEqual(64, cidr, "cidr");
         }
 
@@ -48,10 +46,9 @@ public void TestIpV6TryGuessCidr2()
     {
             var cidrguess = new CidrClassFull();
 
-            byte cidr;
-            bool parsed = cidrguess.TryGuessCidr("2001:0db8::", out cidr);
+            bool parsed = cidrguess.TryGuessCidr("2001:0db8::", out byte cidr);
 
-            Assert.AreEqual(true, parsed, "parsed");
+            Assert.IsTrue(parsed, "parsed");
             Assert.AreEqual(64, cidr, "cidr");
         }
 }

src/TestProject/CidrClassLessUnitTest.cs

@@ -20,10 +20,9 @@ public void TestTryGuessCidrNull()
     {
         var cidrguess = new CidrClassLess();
 
-        byte cidr;
-        bool parsed = cidrguess.TryGuessCidr(null, out cidr);
+        bool parsed = cidrguess.TryGuessCidr(null, out byte cidr);
 
-        Assert.AreEqual(false, parsed, "parsed");
+        Assert.IsFalse(parsed, "parsed");
         Assert.AreEqual(0, cidr, "cidr");
     }
 
@@ -35,10 +34,9 @@ public void TestTryGuessCidrA()
     {
         var cidrguess = new CidrClassLess();
 
-        byte cidr;
-        bool parsed = cidrguess.TryGuessCidr("10.0.0.0", out cidr);
+        bool parsed = cidrguess.TryGuessCidr("10.0.0.0", out byte cidr);
 
-        Assert.AreEqual(true, parsed, "parsed");
+        Assert.IsTrue(parsed, "parsed");
         Assert.AreEqual(32, cidr, "cidr");
     }
 
@@ -50,10 +48,9 @@ public void TestTryGuessCidrB()
     {
         var cidrguess = new CidrClassLess();
 
-        byte cidr;
-        bool parsed = cidrguess.TryGuessCidr("172.0.0.0", out cidr);
+        bool parsed = cidrguess.TryGuessCidr("172.0.0.0", out byte cidr);
 
-        Assert.AreEqual(true, parsed, "parsed");
+        Assert.IsTrue(parsed, "parsed");
         Assert.AreEqual(32, cidr, "cidr");
     }
 
@@ -65,10 +62,9 @@ public void TestTryGuessCidrC()
     {
         var cidrguess = new CidrClassLess();
 
-        byte cidr;
-        bool parsed = cidrguess.TryGuessCidr("192.0.0.0", out cidr);
+        bool parsed = cidrguess.TryGuessCidr("192.0.0.0", out byte cidr);
 
-        Assert.AreEqual(true, parsed, "parsed");
+        Assert.IsTrue(parsed, "parsed");
         Assert.AreEqual(32, cidr, "cidr");
     }
 
@@ -80,10 +76,9 @@ public void TestTryGuessCidrD()
     {
         var cidrguess = new CidrClassLess();
 
-        byte cidr;
-        bool parsed = cidrguess.TryGuessCidr("224.0.0.0", out cidr);
+        bool parsed = cidrguess.TryGuessCidr("224.0.0.0", out byte cidr);
 
-        Assert.AreEqual(true, parsed, "parsed");
+        Assert.IsTrue(parsed, "parsed");
         Assert.AreEqual(32, cidr, "cidr");
     }
 
@@ -95,10 +90,9 @@ public void TestTryGuessCidrE()
     {
         var cidrguess = new CidrClassLess();
 
-        byte cidr;
-        bool parsed = cidrguess.TryGuessCidr("240.0.0.0", out cidr);
+        bool parsed = cidrguess.TryGuessCidr("240.0.0.0", out byte cidr);
 
-        Assert.AreEqual(true, parsed, "parsed");
+        Assert.IsTrue(parsed, "parsed");
         Assert.AreEqual(32, cidr, "cidr");
     }
 
@@ -114,10 +108,9 @@ public void TestIpV6TryGuessCidrNull()
     {
         var cidrguess = new CidrClassLess();
 
-        byte cidr;
-        bool parsed = cidrguess.TryGuessCidr(null, out cidr);
+        bool parsed = cidrguess.TryGuessCidr(null, out byte cidr);
 
-        Assert.AreEqual(false, parsed, "parsed");
+        Assert.IsFalse(parsed, "parsed");
         Assert.AreEqual(0, cidr, "cidr");
     }
 
@@ -129,10 +122,9 @@ public void TestIpV6TryGuessCidr1()
     {
         var cidrguess = new CidrClassLess();
 
-        byte cidr;
-        bool parsed = cidrguess.TryGuessCidr("::", out cidr);
+        bool parsed = cidrguess.TryGuessCidr("::", out byte cidr);
 
-        Assert.AreEqual(true, parsed, "parsed");
+        Assert.IsTrue(parsed, "parsed");
         Assert.AreEqual(128, cidr, "cidr");
     }
 
@@ -144,10 +136,9 @@ public void TestIpV6TryGuessCidr2()
     {
         var cidrguess = new CidrClassLess();
 
-        byte cidr;
-        bool parsed = cidrguess.TryGuessCidr("2001:0db8::", out cidr);
+        bool parsed = cidrguess.TryGuessCidr("2001:0db8::", out byte cidr);
 
-        Assert.AreEqual(true, parsed, "parsed");
+        Assert.IsTrue(parsed, "parsed");
         Assert.AreEqual(128, cidr, "cidr");
     }
 

src/TestProject/ContainsUnitTest.cs

@@ -61,7 +61,7 @@ public void TestContainsStatic3()
             IPNetwork2 ipnetwork2 = null;
 
 #pragma warning disable 0618
-            bool result = IPNetwork2.Contains(ipnetwork, ipnetwork2);
+            IPNetwork2.Contains(ipnetwork, ipnetwork2);
 #pragma warning restore 0618
         }
 
@@ -91,7 +91,7 @@ public void TestContains8()
             var ipnetwork = IPNetwork2.Parse("0.0.0.0/0");
             IPNetwork2 ipnetwork2 = null;
 
-            bool result = ipnetwork.Contains(ipnetwork2);
+            ipnetwork.Contains(ipnetwork2);
         }
 
     /// <summary>
@@ -105,7 +105,7 @@ public void TestContainsStatic1()
             IPAddress ipaddress = null;
 
 #pragma warning disable 0618
-            bool result = IPNetwork2.Contains(ipnetwork, ipaddress);
+            IPNetwork2.Contains(ipnetwork, ipaddress);
 #pragma warning restore 0618
         }
 
@@ -134,7 +134,7 @@ public void TestContains10()
             var ipnetwork = IPNetwork2.Parse("0.0.0.0/0");
             IPAddress ipaddress = null;
 
-            bool result = ipnetwork.Contains(ipaddress);
+            ipnetwork.Contains(ipaddress);
         }
 
     /// <summary>