field array: fix serialization #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turuslan
approved these changes
Nov 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just realized there was an error here. Instead of using the existing implementation of serialization for the field F (https://github.com/Plonky3/Plonky3/blob/eb871f9677ab405b1b2521fdab7df28a1a85f4e5/monty-31/src/monty_31.rs#L155-L168), the manual implementation was first transforming the finite field into canonical form.
Thus, for
FieldArrayonly, finite field elements were transformed into canonical form before being serialized, which wasn't the case for all the other serialization implementations in the codebase.This wasn't critical since deserialization was based on the same principle in the opposite direction, but it wasn't consistent with the rest of the codebase.
I also included a unit test to confirm the serialized results are obtained in the right format.