Skip to content

Conversation

@unnawut
Copy link
Collaborator

@unnawut unnawut commented Dec 5, 2025

🗒️ Description

I was having issue with getting #193 to output the signatures to test vectors. It looks like SSZVector didn't know how to serialize Fp. 3 main changes are done:

See how they are being used in #193.

🔗 Related Issues or PRs

✅ Checklist

  • Ran tox checks to avoid unnecessary CI fails:
    uvx tox
  • Considered adding appropriate tests for the changes.
  • Considered updating the online docs in the ./docs/ directory.

@unnawut unnawut requested a review from tcoratger December 5, 2025 14:56
@unnawut unnawut added the specs Scope: Changes to the specifications label Dec 5, 2025
@unnawut unnawut changed the title feat: make Fp and its vector json serializable feat: make SSZVector of Fp serializable Dec 5, 2025
Copy link
Collaborator

@tcoratger tcoratger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have some small unit tests for this?

Even if this is pretty obvious, that is probably better to have tests in order to confirm that nothing is broken in the future with this.

@unnawut
Copy link
Collaborator Author

unnawut commented Dec 5, 2025

@tcoratger Sorry I forgot to add. Would this be enough? 728f736

Copy link
Collaborator

@tcoratger tcoratger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot :)

@tcoratger tcoratger merged commit aae2d9a into leanEthereum:main Dec 5, 2025
10 checks passed
@unnawut unnawut deleted the fp-json branch December 5, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

specs Scope: Changes to the specifications

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants