[DRAFT] feat: pqsig specs for devnet1#73
Closed
unnawut wants to merge 1 commit intoleanEthereum:mainfrom
Closed
Conversation
Collaborator
Author
|
Closing in favor of #67 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening this PR prematurely for discussion
🗒️ Description
Listing down expected changes if we introduce
SignedMessageBundleto allow a single PQ key to authenticate multiple actions in a slot. The general direction from PQinterop keygen session.We can take another path and just keep the signed messages separate i.e.
SignedBlock,SignedVotebut need more discussion on requiring multiple PQkeys or whether 1 action per slot is really acceptable.Container changes
State::validators: { pubkeys: xmss::containers::PublicKey }BlockBody::attestations: List[SignedMessageBundle]SignedMessageBundle : { block_message: Block, vote_data: Vote, signature: Signature }Signature: { path: HashTreeOpening, rho: Randomness, hashes: List[HashDigest] }-> Added but notSignedBlock-> useSignedMessageBundleinsteadSignedVote-> useSignedMessageBundleinsteadSTF changes
state_transitionfrom receivingsigned_blocktoblockand block signature pre-validatedprocess_bundle(signed_message_bundle)process_attestations()from receivingattestations: List[SignedVote]toList[SignedMessageBundle](TBD)Gossipsub
SignedMessageBundleSignedBlockSignedVoteNote: this looks worse for network optimization
ResResp
BlocksByRootResponseReqResp returnsList[SignedBlock]-> returnsList[SignedMessageBundle]. Ideal?✅ Checklist
toxchecks to avoid unnecessary CI fails:uvx --with=tox-uv tox