Skip to content

Conversation

@fselmo
Copy link
Contributor

@fselmo fselmo commented Oct 27, 2025

🗒️ Description

I think we should move all developer dependencies to the dev dep group and reserve extras for things like optimized or some opt-in features that make sense as optional extras.

This makes it so that uv sync (without necessitating --all-extras) syncs all necessary things for development.

If we merge this before #76, we should add the test framework to dev dependency group and I can rebase the test vector PR to have this. Otherwise this will need a rebase, whichever comes first.


Note: We are making some similar changes in execution-specs that inspired this reorganization. I think this makes sense for us here.

✅ Checklist

  • Ran tox checks to avoid unnecessary CI fails:
    uvx tox -e all-checks,pytest
  • Considered adding appropriate tests for the changes.
  • Considered updating the online docs in the ./docs/ directory.

We should move all developer dependencies to the `dev` dep group and
reserver extras for things like `optimized` or some opt-in features
that make sense as optional extras.

This makes it so that `uv sync` (without necessitating ``--all-extras``)
syncs all necessary things for development.
@fselmo fselmo marked this pull request as draft October 27, 2025 20:42
@fselmo fselmo force-pushed the chore/reorganize-dev-deps branch 2 times, most recently from ca29288 to 3989d43 Compare October 27, 2025 20:51
@fselmo fselmo marked this pull request as ready for review October 27, 2025 20:53
@fselmo fselmo added chore Category: chore tooling Scope: Changes to workspace / project tooling e.g. tox, mypy, ruff, uv, mkdocs labels Oct 27, 2025
@fselmo fselmo changed the title chore: re-organize dev deps; remove unnecessary optional extras chore(tooling): re-organize dev deps; remove unnecessary optional extras Oct 27, 2025
@fselmo fselmo force-pushed the chore/reorganize-dev-deps branch from 3989d43 to 21ad2d6 Compare October 27, 2025 21:02
@fselmo fselmo requested a review from tcoratger October 27, 2025 21:03
@tcoratger tcoratger merged commit 0452e74 into leanEthereum:main Oct 27, 2025
9 checks passed
@fselmo fselmo deleted the chore/reorganize-dev-deps branch October 27, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Category: chore tooling Scope: Changes to workspace / project tooling e.g. tox, mypy, ruff, uv, mkdocs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants