fix(tooling): uvenv lock runner and deps#97
Merged
tcoratger merged 2 commits intoleanEthereum:mainfrom Oct 29, 2025
Merged
Conversation
fselmo
added
bug
Contributor
Author
|
Sorry, should've been fixed in #85 but this finishes cleaning this up I think :) |
- refactor(packages/testing): re-organize pytest.ini file for filler
fselmo
force-pushed
the
fix/tox-uvenv-lock-runner-and-deps
branch
from
7c08afe to
c54d0c8
Compare
tcoratger
approved these changes
Oct 29, 2025
Collaborator
tcoratger
left a comment
tcoratger
left a comment
There was a problem hiding this comment.
Nice that is cleaner for the user, thanks!
unnawut
reviewed
Oct 30, 2025
| - [ ] Ran `tox` checks to avoid unnecessary CI fails: | ||
| ```console | ||
| uvx tox -e all-checks,pytest | ||
| uvx tox |
Collaborator
There was a problem hiding this comment.
Hey @tcoratger this command ends with serving the docs server, can you help exclude mkdocs serve somehow?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
This builds on the changes from #85
I split the dependency groups into appropriate categories, mostly just for organizing instead of having comments -
devstill includes everything. What I hadn't noticed is theuv-venv-lock-runnerfortoxwas not being defined in the right place[testenv](not[tox]). This PR re-organizes everything and gets rid of the need to use--all-packagessincedevdependency group is always synced by default and we now include the package as a dev dependency. This has the benefit of only needinguv sync(without--all-packages) for syncing the full dev environment which is quite nice imo.I re-organized the filler
pytest.iniunder thepackages/testingframework as this makes more sense there.This updates the
toxdocs command to be:docs-buildanddocs-serve- to be more clear.uvx toxrunsall-checks,pytest, anddocs-buildso is now the recommended check for PRs in the PR template as it's quick and covers almost everything.I removed what seem to be unused markdown deps from docs: use mdformat to format markdown files under
docs/#58, @syjn99 if you can sanity check me that we indeed don't use these.✅ Checklist
toxchecks to avoid unnecessary CI fails:uvx tox