fix(specs,testing): Fix serializaiton to use camelCase; refactor model impls#96
Merged
fselmo merged 1 commit intoleanEthereum:mainfrom Oct 29, 2025
Conversation
fselmo
force-pushed
the
fix/refactor-and-fix-model-implementations
branch
from
1469c89 to
c78d349
Compare
tcoratger
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
I realized we are not serializing test vectors to camelCase - overlooked this in #76. This adds this fix and removes redundant re-implementations of strict base models to inherit from
StrictBaseModelinstead.CamelModelfor models to serialize to camelCase for test vectors.StrictBaseModel✅ Checklist
toxchecks to avoid unnecessary CI fails:uvx tox -e all-checks,pytest