Fix/2853 passing flutter command not work on the web #2857
Merged
+251
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kendru98
requested review from
fylyppo,
mateuszwojtczak,
pdenert and
piotruela
as code owners
github-actions
bot
added
the
package: patrol_cli
pdenert
approved these changes
Jan 7, 2026
| @@ -33,6 +33,7 @@ class WebTestBackend { | |||
|
|
|||
| final result = await _processManager.run([ | |||
Collaborator
There was a problem hiding this comment.
We should extract content of this run method call to separate function toFlutterBuildInvocation like it is already donect for ios and macos. This way we'll be able to test this
Kendru98
force-pushed
the
fix/2853-passing-flutter-command-not-work-on-the-web
branch
from
ea81730 to
14386f0
Compare
Kendru98
deleted the
fix/2853-passing-flutter-command-not-work-on-the-web
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2853