Fix/test finder cant find tests in nested dirs #2858
Merged
+32
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jBorkowska
requested review from
fylyppo,
mateuszwojtczak,
pdenert and
piotruela
as code owners
github-actions
bot
added
the
package: patrol_cli
jBorkowska
force-pushed
the
fix/test-finder-cant-find-tests-in-nested-dirs
branch
from
e30e070 to
b52b210
Compare
Collaborator
Author
|
test comment, please ignore |
Collaborator
Author
|
another test comment, please ignore |
Collaborator
|
Dart tests are failing |
Collaborator
Author
|
fixed tests and added a test for this edge case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2835
Test finder, which validates if passed target is a patrol tests, was searching for test files in parent directory of the directory set as test dir, which now can be custom. If nested dir was set, eg.
test/e2e, test finder was searching in<project's root>/testinstead of project's root.