Conversation
yuri91
requested changes
Jan 20, 2025
Maqrkk
force-pushed
the
threading
branch
2 times, most recently
from
3312e49 to
8c1098c
Compare
…ility otherwise globals used by the utility thread will be reset on initialization
The size was wrong when booleans were used as thread locals. We now align the thread local area to 8 bytes and calculate the size based on that.
Since there are now 2 places in the code where a new Worker is made, we move the text of the blob into a variable.
This intrinsic will be used in the ThreadLocalLowering pass to bypass a dependency issue with LinearMemoryHelper.
This pass will make it possible to use wasm threadlocals in genericjs, by creating and calling a function in wasm that will calculate the address in memory of the threadlocal.
This secondary threadingObject is introduced because of Closure mode, and to be consistent across the board we use the same method for all module types.
Since the thread setup is asynchronous, we have to create a custom promise to return the module, and only resolve this when the utility thread has been set up.
yuri91
approved these changes
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.