Remove getPointerElementType calls that can be removed without further support in master.#293
Merged
Remove getPointerElementType calls that can be removed without further support in master.#293
Conversation
yuri91
requested changes
Apr 23, 2025
Member
yuri91
left a comment
yuri91
left a comment
There was a problem hiding this comment.
Looks good, but the CI failed in the clang tests.
Please investigate
Member
Author
|
I see ASAN tests are still failing. I'm looking into it now. |
LLVM sets the type of the this parameter of virtual method thunks to the derived class. This was changed for Cheerp in 88d9836 and there are a dozen or so commits after it to deal with crashes caused by this change. With opaque pointers, the signature of these thunks won't be different anyways (the this type will just be an opaque pointer), and going back to upstream LLVM's behaviour allows us to get rid of some GPETs. This also affects the type of a downcast instruction in the thunk, but I do not think this matters much.
Member
Author
|
Rebased on master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several months of work in this PR.