Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for CheerpOS as a new vendor type in the LLVM Triple system, extending Cheerp compiler support to target CheerpOS environments. This involves adding CheerpOS as a vendor option and updating various compiler toolchain components to handle CheerpOS-specific configurations.
- Added CheerpOS as a new vendor type in the Triple system
- Updated Cheerp toolchain to handle CheerpOS-specific features like shared memory and imported memory
- Modified target selection logic to use Cheerp backend for CheerpOS targets
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| llvm/include/llvm/ADT/Triple.h | Added CheerpOS vendor enum and updated Cheerp-related target detection methods |
| llvm/lib/Support/Triple.cpp | Added CheerpOS vendor name parsing and string conversion support |
| clang/lib/Driver/ToolChains/WebAssembly.h | Updated getWasmFeatures function signature to accept Triple parameter |
| clang/lib/Driver/ToolChains/WebAssembly.cpp | Enhanced Cheerp toolchain with CheerpOS-specific memory configurations and Triple parameter usage |
| clang/lib/Driver/ToolChains/Clang.cpp | Updated function call to pass Triple parameter to getWasmFeatures |
| clang/lib/Driver/Driver.cpp | Added CheerpOS target triple handling and toolchain selection |
| clang/lib/Basic/Targets/WebAssembly.h | Added Triple filtering for CheerpOS targets and CPU validation methods |
| clang/lib/Basic/Targets/WebAssembly.cpp | Implemented CPU name validation for Cheerp target |
| clang/lib/Basic/Targets.cpp | Added CheerpOS target selection logic |
yuri91
reviewed
Aug 12, 2025
yuri91
approved these changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.