Skip to content

Cheerpos fixes3#318

Merged
alexp-sssup merged 3 commits intomasterfrom
cheerpos-fixes3
Aug 12, 2025
Merged

Cheerpos fixes3#318
alexp-sssup merged 3 commits intomasterfrom
cheerpos-fixes3

Conversation

@alexp-sssup
Copy link
Member

No description provided.

@alexp-sssup alexp-sssup requested a review from Copilot August 12, 2025 11:05
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for CheerpOS as a new vendor type in the LLVM Triple system, extending Cheerp compiler support to target CheerpOS environments. This involves adding CheerpOS as a vendor option and updating various compiler toolchain components to handle CheerpOS-specific configurations.

  • Added CheerpOS as a new vendor type in the Triple system
  • Updated Cheerp toolchain to handle CheerpOS-specific features like shared memory and imported memory
  • Modified target selection logic to use Cheerp backend for CheerpOS targets

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
llvm/include/llvm/ADT/Triple.h Added CheerpOS vendor enum and updated Cheerp-related target detection methods
llvm/lib/Support/Triple.cpp Added CheerpOS vendor name parsing and string conversion support
clang/lib/Driver/ToolChains/WebAssembly.h Updated getWasmFeatures function signature to accept Triple parameter
clang/lib/Driver/ToolChains/WebAssembly.cpp Enhanced Cheerp toolchain with CheerpOS-specific memory configurations and Triple parameter usage
clang/lib/Driver/ToolChains/Clang.cpp Updated function call to pass Triple parameter to getWasmFeatures
clang/lib/Driver/Driver.cpp Added CheerpOS target triple handling and toolchain selection
clang/lib/Basic/Targets/WebAssembly.h Added Triple filtering for CheerpOS targets and CPU validation methods
clang/lib/Basic/Targets/WebAssembly.cpp Implemented CPU name validation for Cheerp target
clang/lib/Basic/Targets.cpp Added CheerpOS target selection logic

@alexp-sssup alexp-sssup requested a review from yuri91 August 12, 2025 11:06
Copy link
Member

@yuri91 yuri91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a couple of comments

@alexp-sssup alexp-sssup merged commit b0aca01 into master Aug 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants