GDA: Lower several op_with_overflow intrinsics#321
Merged
alexp-sssup merged 2 commits intomasterfrom Aug 26, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR extends the GlobalDepsAnalyzer to lower additional overflow intrinsics by implementing manual overflow detection for signed arithmetic operations. The change allows these intrinsics to be replaced with explicit arithmetic and comparison operations when compiling with the LLC pass.
- Added lowering support for
sadd_with_overflowandssub_with_overflowintrinsics using bit manipulation techniques - Added lowering support for
smul_with_overflowintrinsic using division-based overflow detection - Fixed missing
continuestatements in existing overflow intrinsic handlers
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
alexp-sssup
force-pushed
the
cheerpos-fixes6
branch
from
8a39851 to
f6187de
Compare
yuri91
reviewed
Aug 26, 2025
llvm/tools/llc/llc.cpp
Outdated
|
|
||
| // Declare success. | ||
| Out->keep(); | ||
| // Try to make the output executable, some build systems depend on it |
To emulate the behavior of native linkers
alexp-sssup
force-pushed
the
cheerpos-fixes6
branch
from
f6187de to
2f539b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.