Conversation
yuri91
approved these changes
Oct 20, 2025
Member
yuri91
left a comment
yuri91
left a comment
There was a problem hiding this comment.
Looks good.
What is the story for asm.js? Do we support threads in general or not? if so, we should fix the compilation of thread local accesses as you did for wasm
TypeOptimizer can now deal with rewriting an intrinsic of type threadlocal_address.
A valid guard is already passed for tls_init. Making guards per variable here would break thread locals, since the guards are global, and so are only executed once, instead of once per thread.
Previously I assumed all access to thread locals would use the threadlocal_address intrinsic. This turns out not to be true. Therefore we need to check every access to a global to see if it is a thread local, and calculate the address differently.
This was originally meant to be a threadlocal, but at the time threadlocals weren't supported. This commit also reverts commit 29a1062.
yuri91
force-pushed
the
threadlocal-constructors
branch
from
9f1c07b to
104982a
Compare
yuri91
force-pushed
the
threadlocal-constructors
branch
from
104982a to
1ea6bd8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.