Fix nested FPM & MPM inside Cheerp Passes for -time-passes to work #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CheerpLowerAtomic and LowerGlobalDestructors were causing a seg fault when ran together with the opt tool and the -time-passes option. Apparently the llvm timer function could not time a pass if there were nested pass managers inside. I removed the FPM & MPM and replaced them with an object of the pass we were adding to them. For testing purposes please try this: /opt/cheerp/bin/opt -march=cheerp -cheerp-linear-output=wasm -cheerp-wasm-no-simd -cheerp-lower-atomics -cheerp-ito -passes="CheerpLowerAtomic,LowerGlobalDestructors" -o io_standard_optimized.bc io_standard_linked.bc
yuri91
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CheerpLowerAtomic and LowerGlobalDestructors were causing a seg fault when ran together with the opt tool and the -time-passes option. Apparently the llvm timer function could not time a pass if there were nested pass managers inside. I removed the FPM & MPM and replaced them with an object of the pass we were adding to them.
For testing purposes please try this:
/opt/cheerp/bin/opt -march=cheerp -cheerp-linear-output=wasm -cheerp-wasm-no-simd -cheerp-lower-atomics -cheerp-ito -passes="CheerpLowerAtomic,LowerGlobalDestructors" -o io_standard_optimized.bc io_standard_linked.bc