Skip to content

Openssl fixes #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexp-sssup merged 3 commits into from
Mar 4, 2026
Merged

Openssl fixes #350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2268929
icf: support the fence instruction
yuri91 Feb 27, 2026
490b9c7
SROA: disable lowering of memcpy to weird integer sizes
yuri91 Mar 2, 2026
ebe3411
relax assertion in registerize
yuri91 Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions llvm/lib/CheerpUtils/IdenticalCodeFolding.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,6 +571,12 @@ bool IdenticalCodeFolding::equivalentInstruction(const llvm::Instruction* A, con
equivalentOperand(a->getCompareOperand(), b->getCompareOperand()) &&
equivalentOperand(a->getNewValOperand(), b->getNewValOperand()));
}
case Instruction::Fence:
{
const FenceInst* a = cast<FenceInst>(A);
const FenceInst* b = cast<FenceInst>(B);
return CacheAndReturn(a->getOrdering() == b->getOrdering() && a->getSyncScopeID() == b->getSyncScopeID());
}
default:
{
#ifndef NDEBUG
Expand Down
2 changes: 1 addition & 1 deletion llvm/lib/CheerpUtils/Registerize.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -810,7 +810,7 @@ void VertexColorer::iterativeDeepening(IterationsCounter& counter)

lowerBound = lowerBoundOnNumberOfColors(/*forceEvaluation*/true);
}
assert(counter.remaining() > 0);
//assert(counter.remaining() > 0);
Copy link

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving the old assertion commented out makes the intent unclear and leaves dead code behind. Prefer either removing it entirely or replacing it with an explicit guard/early return when counter.remaining() == 0 (and, if useful, a short comment explaining why 0 iterations is a valid input).

Suggested change
//assert(counter.remaining() > 0);

Copilot uses AI. Check for mistakes.

uint32_t positiveFriendships = 0;
while (positiveFriendships < friendships.size() && friendships[positiveFriendships].first > 0)
Expand Down
4 changes: 4 additions & 0 deletions llvm/lib/Transforms/Scalar/SROA.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2176,6 +2176,10 @@ static bool isIntegerWideningViableForSlice(const Slice &S,
return false;
if (!S.isSplittable())
return false; // Skip any unsplittable intrinsics.
uint64_t SliceBits = (RelEnd - RelBegin) * 8;
// CHEERP: disallow weird integer sizes like i24 from being created
if (!DL.isByteAddressable() && !DL.isLegalInteger(SliceBits))
return false;
Comment on lines +2179 to +2182
Copy link

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a regression test for the new non-byte-addressable DataLayout behavior here (e.g., a module with datalayout including 'b' and a 3-byte memintrinsic slice) to ensure SROA no longer tries integer widening that would require creating illegal integer types like i24.

Copilot uses AI. Check for mistakes.
} else {
return false;
}
Expand Down
Loading