Updating cheerp x licensing #347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingfrog27
force-pushed
the
updating-cheerpX-licensing
branch
from
b483a24 to
7884d36
Compare
GabrielaReyna
requested changes
Jan 28, 2026
Contributor
GabrielaReyna
left a comment
GabrielaReyna
left a comment
There was a problem hiding this comment.
Looks good to me overall.
- I would request a review from Stefano on the content itself.
- On the links were contacting sales is suggested, we are redirecting to the non-markdown licensing page, where they need to click another link to go to the contact form. Can we send them directly to the contact form instead?
Member
|
Content is ok, it's modeled on CheerpJ as the conditions are intended to be identical. I'll merge this version but feel free to improve the contact link later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly just stuck as close to CJ's licensing page as possible.
I think for future improvement we could mention our options for small businesses and NGO's/acedemic or public sector organisations more explicitely. But it is in the examples and opted for more consistency.
Lastly I rebased from the updating depend tree after no issues were found to (hopefully) prevent needing a seperate rebase from main before merging.