Skip to content

CID-3590: Skip manifest files with wrong name#84

Merged
mohamedlajmileanix merged 2 commits intomainfrom
feature/CID-3590/picking-up-wrong-file-as-manifest
Mar 7, 2025
Merged

CID-3590: Skip manifest files with wrong name#84
mohamedlajmileanix merged 2 commits intomainfrom
feature/CID-3590/picking-up-wrong-file-as-manifest

Conversation

@mohamedlajmileanix
Copy link
Contributor

@mohamedlajmileanix mohamedlajmileanix commented Mar 4, 2025

🛠 Changes made

Please explain here the changes you made in this PR.

✨ Type of change

  • Bug fix (non-breaking change which fixes an issue)

🧪 How Has This Been Tested?

  • scanGitHubResources should not send manifest files over WebSocket for manifest files with wrong name
  • should not process push event with wrong name

🏎 Checklist:

  • My commit message clearly reflects the changes made
  • Assigned the appropriate labels (version, PR type, etc.)

@mohamedlajmileanix mohamedlajmileanix requested a review from a team as a code owner March 4, 2025 07:46
@mohamedlajmileanix mohamedlajmileanix added the bug Something isn't working label Mar 4, 2025
@mohamedlajmileanix mohamedlajmileanix changed the title CID-3590: Fix picking up wrong files as manifest files CID-3590: Skip manifest files with wrong name Mar 4, 2025
@github-actions
Copy link

github-actions bot commented Mar 4, 2025

LeanIX GitHub Agent Code Coverage

File Coverage [93.24%] 🍏
Constants.kt 100% 🍏
GitHubScanningService.kt 94.24% 🍏
WebhookEventService.kt 91.57% 🍏
Total Project Coverage 71.87% 🍏

@mohamedlajmileanix mohamedlajmileanix merged commit f783383 into main Mar 7, 2025
4 checks passed
@mohamedlajmileanix mohamedlajmileanix temporarily deployed to ghcr:leanix-github-agent March 7, 2025 08:16 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Development

Successfully merging this pull request may close these issues.

2 participants