Tree.Data.ForwardRuleMatches: fix erasure of consumed matches#299
Merged
Tree.Data.ForwardRuleMatches: fix erasure of consumed matches#299
Conversation
The central function for updating forward rule matches had a bug that led to consumed matches (those that we've already tried to apply, successfully or unsuccessfully) not being removed. Hence, we would try to apply the same matches potentially many times. This involves checking whether a hypothesis of the resulting type already exists, which means one defeq check for each hyp in the context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The central function for updating forward rule matches had a bug that
led to consumed matches (those that we've already tried to apply,
successfully or unsuccessfully) not being removed. Hence, we would try
to apply the same matches potentially many times. This involves checking
whether a hypothesis of the resulting type already exists, which means
one defeq check for each hyp in the context.